Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tizen] Supports Picker.TitleColor, FontSize, FontFamily and FontAttr #4839

Merged
merged 1 commit into from Dec 21, 2018

Conversation

rookiejava
Copy link
Collaborator

Description of Change

Added TitleColor property for setting color for the Picker.Title and FontSize/FontFamily/FontAttributes as well. This PR is an addendum to the changes in #4701 and #662.

Issues Resolved

API Changes

None

Platforms Affected

  • Tizen

Behavioral/Visual Changes

Just like other platforms, on Tizen, the visual representation of a Picker is now similar to a Entry (not a Button). Plus, Title is shown as a placeholder.

Before/After Screenshots

Before After

Testing Procedure

Use ControlGallery (Picker Gallery)

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@StephaneDelcroix StephaneDelcroix merged commit 2a0b344 into xamarin:master Dec 21, 2018
@rookiejava rookiejava deleted the picker-titlecolor-tizen branch December 24, 2018 04:00
@samhouts samhouts added this to Done in v3.6.0 Dec 26, 2018
andreinitescu pushed a commit to andreinitescu/Xamarin.Forms that referenced this pull request Jan 29, 2019
@samhouts samhouts added this to Done in v4.0.0 Feb 2, 2019
@samhouts samhouts removed this from Done in v3.6.0 Feb 2, 2019
@samhouts samhouts modified the milestones: 4.0.0, 3.6.0 Feb 6, 2019
@samhouts samhouts removed this from Done in v4.0.0 Feb 7, 2019
@samhouts samhouts added this to Done in v3.6.0 Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v3.6.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants