This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Android] fixes issue content set after an await is not visible #4861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… visibility changed.
hartez
suggested changes
Jan 2, 2019
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1332.cs
Show resolved
Hide resolved
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1760.cs
Show resolved
Hide resolved
samhouts
added
the
blocker
StephaneDelcroix
approved these changes
Jan 7, 2019
hartez
approved these changes
Jan 15, 2019
|
build --uitests |
samhouts
previously requested changes
Jan 17, 2019
There was a problem hiding this comment.
Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Issue1760_1.cs(25,30): Error CS0103: The name 'Before' does not exist in the current context
--
| Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Issue1760_1.cs(26,30): Error CS0103: The name 'After' does not exist in the current context
| Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Issue1760_1.cs(29,30): Error CS0103: The name 'Before' does not exist in the current context
| Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Issue1760_1.cs(30,30): Error CS0103: The name 'After' does not exist in the current context
| Process 'msbuild.exe' exited with code '1'.
|
build --uitests |
|
These test failures don't look like they have anything to do with these changes (especially not the iOS ones). |
3 tasks
samhouts
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added calling
RequestLayouton parent Layout when adding child in current Layout.Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
before
after
Testing Procedure
PR Checklist