[C, iOS, AND, UWP] TabbedPage SelectedTabColor and UnselectedTabColor #4899

jfversluis · 2019-01-04T15:52:24Z

Description of Change

I opened a previous PR (#3519) for this but that was an iOS-specific one, after the idea of #3478.
In that PR, we got the idea to make it available in general rather than via platform-specifics. This is the PR to do that.

There was already an Android platform-specific for this, I have marked that as obsolete in favor of this.

Issues Resolved

fixes Allow TintColor and UnselectedItemTintColor as platform-specifics #3478

API Changes

Added:

Color TabbedPage.UnselectedTabColorProperty { get; set; } //Bindable Property
Color TabbedPage.SelectedTabColorProperty { get; set; } //Bindable Property

Platforms Affected

Core/XAML (all platforms)
iOS
Android
UWP

Behavioral/Visual Changes

The user is now able to specify a separate color for a selected and unselected tab. There shouldn't be any behavioral changes. Android users of the "old" On<Android>().SetBarItemColor(Color.Red); and On<Android>().SetBarSelectedItemColor(Color.White); will notice that these are now marked as obsolete and are directed to this new method which does the same.

Before/After Screenshots

Android

Before:

After:

iOS

Before:

After:

UWP

Before:

After:

Testing Procedure

Added a case to the gallery root page RootPages Gallery -> Tab->Content.

Original: https://www.dropbox.com/s/4zred5fkizo9y92/SelectedTabColor.mov?dl=0

PR Checklist

Has automated tests
Rebased on top of the target branch at time of PR
Changes adhere to coding standard

jfversluis · 2019-01-07T10:15:39Z

Can I do anything about the failing tests?

Xamarin.Forms.Platform.UAP/TabbedPageRenderer.cs

mattleibow

LGTM

StephaneDelcroix

almost there

Xamarin.Forms.Core/TabbedPage.cs

Xamarin.Forms.Core/PlatformConfiguration/AndroidSpecific/TabbedPage.cs

jfversluis · 2019-01-23T10:46:22Z

Removed last calls to (now) obsolete members in Android which caused the build to fail, sorry about that 🙂

Xamarin.Forms.Controls/RootPages/RootTabbedContentPage.cs

mattleibow

I think we accidentally dropped support for the platform specific. What we can do is make the platform specific just set the real property. This way, we have all new and beautiful code, but the old platform specifics still work.

Xamarin.Forms.Core/TabbedPage.cs

Xamarin.Forms.Platform.Android/AppCompat/TabbedPageRenderer.cs

Xamarin.Forms.Core/PlatformConfiguration/AndroidSpecific/TabbedPage.cs

Xamarin.Forms.Platform.Android/AppCompat/TabbedPageRenderer.cs

jfversluis · 2019-01-24T07:40:36Z

@mattleibow I see your point, I'm just not a big fan of multiple ways to do the same thing, that is why I chose to deprecate the one method. Still, for that time I might be able to change the implementation to set the new property. Else we'll have two properties and two ways of doing the same thing. I'm even less of a fan of that 😉

This would also solve the (accidental) dropping the old way. Does that make sense?

Edit: Already made some changes, just awaiting the naming and deprecation then I guess!

mattleibow

Looking better. Just had a thought that if we are setting the new property via the old one, we don't actually need to check the old one anymore.

Xamarin.Forms.Platform.Android/AppCompat/TabbedPageRenderer.cs

Xamarin.Forms.Core/PlatformConfiguration/AndroidSpecific/TabbedPage.cs

jfversluis · 2019-02-08T10:13:04Z

Thanks @mattleibow ! Makes sense, I think I got all that you meant

mattleibow

I think we are good.

Xamarin.Forms.Core/PlatformConfiguration/AndroidSpecific/TabbedPage.cs

Co-Authored-By: jfversluis <github@geraldversluis.nl>

jfversluis · 2019-02-22T13:04:58Z

Suggestion batch committed 😎 thanks @samhouts !

…xamarin#4899) * Implemented Core and iOS * Implemented Android * Supressed platform specific obsolete warnings for now * Implemented UWP * Make selected page on UWP not rely on title * Review feedback * Removed references to (now) obsolete members * Review feedback fixes * Code review feedback * Changed obsolete msg to reflect right XF version * Apply suggestions from code review Co-Authored-By: jfversluis <github@geraldversluis.nl> fixes xamarin#3478

jfversluis added 4 commits January 4, 2019 16:44

Implemented Core and iOS

a319a2f

Implemented Android

dc7f05b

Supressed platform specific obsolete warnings for now

e221292

Implemented UWP

90a3b7e

jfversluis requested a review from StephaneDelcroix as a code owner January 4, 2019 15:52

jfversluis changed the title ~~Feature/3478 unselectedtabcolor~~ [C, iOS, AND, UWP] TabbedPage SelectedTabColor and UnselectedTabColor Jan 4, 2019

CZEMacLeod reviewed Jan 7, 2019

View reviewed changes

Xamarin.Forms.Platform.UAP/TabbedPageRenderer.cs Outdated Show resolved Hide resolved

jfversluis and others added 2 commits January 7, 2019 14:07

Make selected page on UWP not rely on title

e6df536

Merge branch 'master' into feature/3478-unselectedtabcolor

4727926

samhouts added t/enhancement ➕ deprecation Public API has been deprecated e/3 🕒 3 labels Jan 7, 2019

samhouts added this to In Review in v3.6.0 Jan 7, 2019

samhouts requested a review from mattleibow January 9, 2019 22:09

samhouts assigned mattleibow and StephaneDelcroix Jan 9, 2019

mattleibow approved these changes Jan 10, 2019

View reviewed changes

StephaneDelcroix suggested changes Jan 15, 2019

View reviewed changes

Xamarin.Forms.Core/TabbedPage.cs Outdated Show resolved Hide resolved

Xamarin.Forms.Core/PlatformConfiguration/AndroidSpecific/TabbedPage.cs Outdated Show resolved Hide resolved

Review feedback

331107a

samhouts moved this from In Review to In Progress in v3.6.0 Jan 15, 2019

StephaneDelcroix approved these changes Jan 23, 2019

View reviewed changes

Removed references to (now) obsolete members

c5b382b

mattleibow reviewed Jan 23, 2019

View reviewed changes

Xamarin.Forms.Controls/RootPages/RootTabbedContentPage.cs Outdated Show resolved Hide resolved

mattleibow suggested changes Jan 23, 2019

View reviewed changes

Review feedback fixes

8d15d7b

mattleibow reviewed Jan 24, 2019

View reviewed changes

samhouts added this to In Progress in v4.0.0 Feb 2, 2019

samhouts removed this from In Progress in v3.6.0 Feb 2, 2019

jfversluis and others added 3 commits February 8, 2019 11:10

Code review feedback

e08f1f9

Changed obsolete msg to reflect right XF version

cefe5d5

Merge branch 'master' into feature/3478-unselectedtabcolor

1a7ba1b

mattleibow approved these changes Feb 15, 2019

View reviewed changes

samhouts added the API-change Heads-up to reviewers that this PR may contain an API change label Feb 21, 2019

samhouts suggested changes Feb 21, 2019

View reviewed changes

Apply suggestions from code review

4ff52af

Co-Authored-By: jfversluis <github@geraldversluis.nl>

samhouts approved these changes Feb 27, 2019

View reviewed changes

samhouts changed the base branch from master to 4.0.0 March 1, 2019 23:46

samhouts merged commit e60bfde into xamarin:4.0.0 Mar 1, 2019

v4.0.0 automation moved this from In Progress to Done Mar 1, 2019

jfversluis deleted the feature/3478-unselectedtabcolor branch March 2, 2019 11:17

jfversluis mentioned this pull request Mar 4, 2019

[Android] TabbedPage Add BarSelectedTextColor #3281

Closed

samhouts added this to the 4.0.0 milestone Mar 8, 2019

rookiejava mentioned this pull request May 13, 2019

[Tizen] Support to TabbedPage.BarTextColor, SelctedTabColor, UnselecedTabColor #6183

Merged

3 tasks

MitchBomcanhao mentioned this pull request May 28, 2019

[Bug] IndexOutOfRangeException on TabbedPage with UWP (Forms 4.0) #6323

Closed

jfversluis mentioned this pull request Jun 14, 2019

[Bug] Shell - Shell.TabBarTitleColor no longer sets the active color for the tabbar on iOS #6519

Closed

samhouts added p/iOS 🍎 p/Android p/UWP labels Jul 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[C, iOS, AND, UWP] TabbedPage SelectedTabColor and UnselectedTabColor #4899

[C, iOS, AND, UWP] TabbedPage SelectedTabColor and UnselectedTabColor #4899

jfversluis commented Jan 4, 2019 •

edited

jfversluis commented Jan 7, 2019

mattleibow left a comment

StephaneDelcroix left a comment

jfversluis commented Jan 23, 2019

mattleibow left a comment •

edited

jfversluis commented Jan 24, 2019 •

edited

mattleibow left a comment

jfversluis commented Feb 8, 2019

mattleibow left a comment

jfversluis commented Feb 22, 2019

[C, iOS, AND, UWP] TabbedPage SelectedTabColor and UnselectedTabColor #4899

[C, iOS, AND, UWP] TabbedPage SelectedTabColor and UnselectedTabColor #4899

Conversation

jfversluis commented Jan 4, 2019 • edited

Description of Change

Issues Resolved

API Changes

Platforms Affected

Behavioral/Visual Changes

Before/After Screenshots

Testing Procedure

PR Checklist

jfversluis commented Jan 7, 2019

mattleibow left a comment

Choose a reason for hiding this comment

StephaneDelcroix left a comment

Choose a reason for hiding this comment

jfversluis commented Jan 23, 2019

mattleibow left a comment • edited

Choose a reason for hiding this comment

jfversluis commented Jan 24, 2019 • edited

mattleibow left a comment

Choose a reason for hiding this comment

jfversluis commented Feb 8, 2019

mattleibow left a comment

Choose a reason for hiding this comment

jfversluis commented Feb 22, 2019

jfversluis commented Jan 4, 2019 •

edited

mattleibow left a comment •

edited

jfversluis commented Jan 24, 2019 •

edited