This repository has been archived by the owner on May 1, 2024. It is now read-only.
[C] add null check for FlexLayout.OnPropChanged #5012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -344,6 +344,8 @@ void OnChildPropertyChanged(object sender, PropertyChangedEventArgs e) | |||
| if ( e.PropertyName == WidthRequestProperty.PropertyName | |||
| || e.PropertyName == HeightRequestProperty.PropertyName) { | |||
| var item = (sender as FlexLayout)?._root ?? GetFlexItem((BindableObject)sender); | |||
| if (item == null) | |||
There was a problem hiding this comment.
this code is repeated 4 times, but can't be moved a level higher, as it would imply retrieving the item for all possible property changed.
Liam2349
added a commit
to Liam2349/Xamarin.Forms
that referenced
this pull request
Jan 19, 2019
…t, (xamarin#5012), my previous solution did not consider that the method is called for more than just the stated cases, and that the "item" retrieval and null check are not needed every time this method is hit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We had null checks in 3 places, not the fourth one. and that case was
hit by #5001.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist