Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Android] Fix ImageRenderer URI #5241

Merged
merged 3 commits into from
Feb 14, 2019
Merged

[Android] Fix ImageRenderer URI #5241

merged 3 commits into from
Feb 14, 2019

Conversation

rmarinho
Copy link
Member

Description of Change

Don't dispose if newImage set is null.

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@rmarinho rmarinho changed the base branch from master to 3.5.0 February 13, 2019 19:09
@samhouts samhouts added a/listview Problems with the ListView/TableView blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/2 🕑 2 i/regression p/Android t/bug 🐛 labels Feb 13, 2019
@samhouts samhouts removed the request for review from StephaneDelcroix February 13, 2019 21:42
@samhouts samhouts merged commit 116000f into 3.5.0 Feb 14, 2019
@samhouts samhouts deleted the fix5172 branch February 14, 2019 00:22
@samhouts samhouts added this to the 3.5.0 milestone Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samhouts samhouts samhouts approved these changes

@kingces95 kingces95 Awaiting requested review from kingces95

Assignees

@kingces95 kingces95

@samhouts samhouts

Labels
a/listview Problems with the ListView/TableView blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/2 🕑 2 i/regression p/Android t/bug 🐛
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@rmarinho @samhouts @StephaneDelcroix @kingces95 @PureWeen