Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Tizen] Add CollectionView Tizen Renderer #5364

Merged
merged 2 commits into from
Mar 14, 2019

Conversation

myroot
Copy link
Contributor

@myroot myroot commented Feb 25, 2019

Description of Change

Implementation CollectionView Tizen Renderer
Implementation tizen layer CollectionView

  • Unsupported feature
    • SnapPointsAlignment.Center / SnapPointsAlignment.End

Issues Resolved

API Changes

None

Platforms Affected

  • Tizen

Behavioral/Visual Changes

None

Before/After Screenshots

5cc961c6-02ab-11e9-8e37-fa8f83de665b10c5bf80-2eee-11e9-8ec0-dfa6ca64fb9a
49669880-2ef0-11e9-8f10-6337a5d2d526

Testing Procedure

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

* Tizen CollectionView implementation initial commit

 - first working version
 - only support LinearLayout(listview)

* Add more feature

 * Implement INotifyCollectionChanged
 * Implement EmptyView

* Implemnt SnapPoints, ScrollTo

* Fix MakeVisible option

* Add GridLayoutManager (xamarin#271)

* Fix GetScrollCanvasSize issue

* Enhance ItemAdaptor

 - Measure Item size with data binding
  Item size is determined with first item
 - Extract ItemDefaultTemplateAdaptor from ItemTemplateAdaptor

* Remove debug message

* Implement SelectableItemsView

* Fix ghost view issue

* Fix TV profile button effect issue

* Clean up code space and refactoring ScrollTo method
Copy link
Collaborator

@rookiejava rookiejava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmarinho
Copy link
Member

rmarinho commented Mar 1, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@samhouts samhouts added this to In Review in v4.1.0 Mar 2, 2019
@samhouts samhouts removed this from In Review in v4.0.0 Mar 2, 2019
@samhouts samhouts requested a review from kingces95 March 7, 2019 18:07
@samhouts samhouts requested review from rmarinho and removed request for kingces95 March 13, 2019 03:40
@samhouts samhouts assigned rookiejava and rmarinho and unassigned kingces95 Mar 13, 2019
@rmarinho rmarinho merged commit 07ada19 into xamarin:master Mar 14, 2019
v4.1.0 automation moved this from In Review to Done Mar 14, 2019
adrianknight89 pushed a commit to adrianknight89/Xamarin.Forms that referenced this pull request Mar 29, 2019
…n#3172

* [Tizen] Add CollectionView Tizen Renderer (xamarin#259)

* Tizen CollectionView implementation initial commit

 - first working version
 - only support LinearLayout(listview)

* Add more feature

 * Implement INotifyCollectionChanged
 * Implement EmptyView

* Implemnt SnapPoints, ScrollTo

* Fix MakeVisible option

* Add GridLayoutManager (xamarin#271)

* Fix GetScrollCanvasSize issue

* Enhance ItemAdaptor

 - Measure Item size with data binding
  Item size is determined with first item
 - Extract ItemDefaultTemplateAdaptor from ItemTemplateAdaptor

* Remove debug message

* Implement SelectableItemsView

* Fix ghost view issue

* Fix TV profile button effect issue

* Clean up code space and refactoring ScrollTo method

* Fix collectionView emptyview (xamarin#277)
codemillmatt pushed a commit to codemillmatt/Xamarin.Forms that referenced this pull request Apr 19, 2019
…n#3172

* [Tizen] Add CollectionView Tizen Renderer (xamarin#259)

* Tizen CollectionView implementation initial commit

 - first working version
 - only support LinearLayout(listview)

* Add more feature

 * Implement INotifyCollectionChanged
 * Implement EmptyView

* Implemnt SnapPoints, ScrollTo

* Fix MakeVisible option

* Add GridLayoutManager (xamarin#271)

* Fix GetScrollCanvasSize issue

* Enhance ItemAdaptor

 - Measure Item size with data binding
  Item size is determined with first item
 - Extract ItemDefaultTemplateAdaptor from ItemTemplateAdaptor

* Remove debug message

* Implement SelectableItemsView

* Fix ghost view issue

* Fix TV profile button effect issue

* Clean up code space and refactoring ScrollTo method

* Fix collectionView emptyview (xamarin#277)
@samhouts samhouts added this to Done in v4.2.0 May 29, 2019
@samhouts samhouts removed this from Done in v4.1.0 May 29, 2019
@samhouts samhouts added this to the 4.1.0 milestone Jun 4, 2019
@samhouts samhouts removed this from Done in v4.2.0 Jun 4, 2019
@samhouts samhouts added this to Done in v4.1.0 Jun 4, 2019
AxelUser pushed a commit to AxelUser/Xamarin.Forms that referenced this pull request Jun 15, 2019
…n#3172

* [Tizen] Add CollectionView Tizen Renderer (xamarin#259)

* Tizen CollectionView implementation initial commit

 - first working version
 - only support LinearLayout(listview)

* Add more feature

 * Implement INotifyCollectionChanged
 * Implement EmptyView

* Implemnt SnapPoints, ScrollTo

* Fix MakeVisible option

* Add GridLayoutManager (xamarin#271)

* Fix GetScrollCanvasSize issue

* Enhance ItemAdaptor

 - Measure Item size with data binding
  Item size is determined with first item
 - Extract ItemDefaultTemplateAdaptor from ItemTemplateAdaptor

* Remove debug message

* Implement SelectableItemsView

* Fix ghost view issue

* Fix TV profile button effect issue

* Clean up code space and refactoring ScrollTo method

* Fix collectionView emptyview (xamarin#277)
@myroot myroot deleted the add-collectionview-on-tizen branch November 27, 2019 05:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
v4.1.0
  
Done
Development

Successfully merging this pull request may close these issues.

Xamarin.Forms.CollectionView Spec
5 participants