Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure BindingContext is properly passed to CreateDefault in UWP ListView #259

Merged
merged 1 commit into from Jul 18, 2016

Conversation

@jassmith
Copy link
Contributor

commented Jul 15, 2016

Description of Change

Fix regression where CreateDefault would be passed a ToString variant of the ViewModel in the ItemsSource instead of the ViewModel directly.

Bugs Fixed

API Changes

None

Behavioral Changes

On UWP/WinRT CreateDefault now gets passed the item from your ItemsSource and not the item.ToString () result. This is in line with iOS/Android and the previous UWP behavior of 2.0.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@samhouts

This comment has been minimized.

Copy link
Member

commented Jul 15, 2016

👍

1 similar comment
@rmarinho

This comment has been minimized.

Copy link
Member

commented Jul 18, 2016

👍

@rmarinho rmarinho merged commit 238c00b into master Jul 18, 2016
2 checks passed
2 checks passed
Windows-Debug-Cycle6 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 6 :: Windows Debug : Tests passed: 3375, ignored: 8
Details
Windows-Debug-Cycle7 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle7 :: Windows Debug : Tests passed: 3375, ignored: 8
Details
@rmarinho rmarinho deleted the fix-bz41205 branch Jul 18, 2016
@samhouts samhouts added this to the 2.3.2 milestone Jun 27, 2018
myroot added a commit to myroot/Xamarin.Forms that referenced this pull request Feb 24, 2019
* Tizen CollectionView implementation initial commit

 - first working version
 - only support LinearLayout(listview)

* Add more feature

 * Implement INotifyCollectionChanged
 * Implement EmptyView

* Implemnt SnapPoints, ScrollTo

* Fix MakeVisible option

* Add GridLayoutManager (xamarin#271)

* Fix GetScrollCanvasSize issue

* Enhance ItemAdaptor

 - Measure Item size with data binding
  Item size is determined with first item
 - Extract ItemDefaultTemplateAdaptor from ItemTemplateAdaptor

* Remove debug message

* Implement SelectableItemsView

* Fix ghost view issue

* Fix TV profile button effect issue

* Clean up code space and refactoring ScrollTo method
rmarinho added a commit that referenced this pull request Mar 14, 2019
* [Tizen] Add CollectionView Tizen Renderer (#259)

* Tizen CollectionView implementation initial commit

 - first working version
 - only support LinearLayout(listview)

* Add more feature

 * Implement INotifyCollectionChanged
 * Implement EmptyView

* Implemnt SnapPoints, ScrollTo

* Fix MakeVisible option

* Add GridLayoutManager (#271)

* Fix GetScrollCanvasSize issue

* Enhance ItemAdaptor

 - Measure Item size with data binding
  Item size is determined with first item
 - Extract ItemDefaultTemplateAdaptor from ItemTemplateAdaptor

* Remove debug message

* Implement SelectableItemsView

* Fix ghost view issue

* Fix TV profile button effect issue

* Clean up code space and refactoring ScrollTo method

* Fix collectionView emptyview (#277)
adrianknight89 added a commit to adrianknight89/Xamarin.Forms that referenced this pull request Mar 29, 2019
…n#3172

* [Tizen] Add CollectionView Tizen Renderer (xamarin#259)

* Tizen CollectionView implementation initial commit

 - first working version
 - only support LinearLayout(listview)

* Add more feature

 * Implement INotifyCollectionChanged
 * Implement EmptyView

* Implemnt SnapPoints, ScrollTo

* Fix MakeVisible option

* Add GridLayoutManager (xamarin#271)

* Fix GetScrollCanvasSize issue

* Enhance ItemAdaptor

 - Measure Item size with data binding
  Item size is determined with first item
 - Extract ItemDefaultTemplateAdaptor from ItemTemplateAdaptor

* Remove debug message

* Implement SelectableItemsView

* Fix ghost view issue

* Fix TV profile button effect issue

* Clean up code space and refactoring ScrollTo method

* Fix collectionView emptyview (xamarin#277)
codemillmatt added a commit to codemillmatt/Xamarin.Forms that referenced this pull request Apr 19, 2019
…n#3172

* [Tizen] Add CollectionView Tizen Renderer (xamarin#259)

* Tizen CollectionView implementation initial commit

 - first working version
 - only support LinearLayout(listview)

* Add more feature

 * Implement INotifyCollectionChanged
 * Implement EmptyView

* Implemnt SnapPoints, ScrollTo

* Fix MakeVisible option

* Add GridLayoutManager (xamarin#271)

* Fix GetScrollCanvasSize issue

* Enhance ItemAdaptor

 - Measure Item size with data binding
  Item size is determined with first item
 - Extract ItemDefaultTemplateAdaptor from ItemTemplateAdaptor

* Remove debug message

* Implement SelectableItemsView

* Fix ghost view issue

* Fix TV profile button effect issue

* Clean up code space and refactoring ScrollTo method

* Fix collectionView emptyview (xamarin#277)
AxelUser added a commit to AxelUser/Xamarin.Forms that referenced this pull request Jun 15, 2019
…n#3172

* [Tizen] Add CollectionView Tizen Renderer (xamarin#259)

* Tizen CollectionView implementation initial commit

 - first working version
 - only support LinearLayout(listview)

* Add more feature

 * Implement INotifyCollectionChanged
 * Implement EmptyView

* Implemnt SnapPoints, ScrollTo

* Fix MakeVisible option

* Add GridLayoutManager (xamarin#271)

* Fix GetScrollCanvasSize issue

* Enhance ItemAdaptor

 - Measure Item size with data binding
  Item size is determined with first item
 - Extract ItemDefaultTemplateAdaptor from ItemTemplateAdaptor

* Remove debug message

* Implement SelectableItemsView

* Fix ghost view issue

* Fix TV profile button effect issue

* Clean up code space and refactoring ScrollTo method

* Fix collectionView emptyview (xamarin#277)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.