-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Conversation
@@ -8,7 +8,12 @@ | |||
|
|||
namespace Xamarin.Forms | |||
{ | |||
[ContentProperty("Items")] | |||
public class ShellTab : ShellSection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do Tab
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the mid-term goal is to deprecate NavigationPage, TabbedPage, and MDP, I'm fine if we have some overlap in names. otherwise, it's better to avoid confusion
public class TabContent : ShellContent | ||
{ | ||
} | ||
|
||
[ContentProperty("Content")] | ||
public class ShellContent : BaseShellItem, IShellContentController |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have a Content alias, removing the Shell
here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not, as ShellContent has a property Content. I'm fine with an alias, be we need a better name, something like "Page", but not that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll probably merge as is for pre8 testing
But would there be a way to achieve what David is asking with simplifying down the names so we could have
<Shell>
<Tab>
<Content>
</Content>
</Tab>
</Shell>
it does seem confusing to now have something called
TabContent inside the Xamarin.Forms namespace that only belongs to Shell
* [C] alias shell names * - change from ShellTab to Tab
API Additions
Tab alias for a ShellSection
TabContent alias for a ShellContent
FlyoutItem alias for a ShellItem
Shell has a property now called Flyout that maps to Items