Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[C] alias shell names #5624

Merged
merged 2 commits into from
Mar 27, 2019
Merged

[C] alias shell names #5624

merged 2 commits into from
Mar 27, 2019

Conversation

StephaneDelcroix
Copy link
Member

@StephaneDelcroix StephaneDelcroix commented Mar 20, 2019

API Additions

Tab alias for a ShellSection
TabContent alias for a ShellContent
FlyoutItem alias for a ShellItem

Shell has a property now called Flyout that maps to Items

@@ -8,7 +8,12 @@

namespace Xamarin.Forms
{
[ContentProperty("Items")]
public class ShellTab : ShellSection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do Tab instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the mid-term goal is to deprecate NavigationPage, TabbedPage, and MDP, I'm fine if we have some overlap in names. otherwise, it's better to avoid confusion

@samhouts samhouts added a/shell 🐚 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. labels Mar 26, 2019
public class TabContent : ShellContent
{
}

[ContentProperty("Content")]
public class ShellContent : BaseShellItem, IShellContentController
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have a Content alias, removing the Shell here as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not, as ShellContent has a property Content. I'm fine with an alias, be we need a better name, something like "Page", but not that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll probably merge as is for pre8 testing

But would there be a way to achieve what David is asking with simplifying down the names so we could have

<Shell>
        <Tab>
            <Content>
                
            </Content>
        </Tab>
</Shell>

it does seem confusing to now have something called
TabContent inside the Xamarin.Forms namespace that only belongs to Shell

@PureWeen PureWeen marked this pull request as ready for review March 27, 2019 18:24
@PureWeen PureWeen merged commit 517642b into 4.0.0 Mar 27, 2019
@PureWeen PureWeen deleted the shell-alias branch March 27, 2019 18:52
@samhouts samhouts added this to the 4.0.0 milestone Mar 28, 2019
AxelUser pushed a commit to AxelUser/Xamarin.Forms that referenced this pull request Jun 15, 2019
* [C] alias shell names

* - change from ShellTab to Tab
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Jul 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/shell 🐚 approved Has two approvals, no pending reviews, and no changes requested blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants