This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS] Fix: memory leak when Navigation.RemovePage is used #5695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The leak occurs in a MasterDetailPage.Detail = NavigationPage(ContentPage) scenario if the ContentPage has ToolBarItems. (ToolBarItems create a strong dependency therefore the ViewController of the NavigationPage must be explicitly disposed)
|
@kicsiede Just a suggestion, adding an unit test for this would be great... It's really awesome you were able to find and track this down, memory leaks are 😨 |
|
Hey do you think you can you add a UITest ?! thanks |
|
@rmarinho please check |
paymicro
reviewed
Mar 27, 2019
| namespace Xamarin.Forms.Controls.Issues | ||
| { | ||
| [Preserve(AllMembers = true)] | ||
| [Issue(IssueTracker.Github, 5555, "Memory leak when SwitchCell or EntryCell", PlatformAffected.iOS)] |
There was a problem hiding this comment.
copy/paste detected =)
I'll think about something more universal for any controls when checking for memory leaks.
There was a problem hiding this comment.
I agree, I was gonna say we had a test for most of the renderers where we pushed a page with a control, and make sure it was collected, I wonder if we can do that in the dynamic gallery test you created Pavel
paymicro
approved these changes
Apr 3, 2019
3 tasks
samhouts
requested review from
paymicro and
rmarinho
and removed request for
paymicro
rmarinho
approved these changes
May 8, 2019
samhouts
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The leak occurs in a MasterDetailPage.Detail = NavigationPage(ContentPage) scenario if the ContentPage has ToolBarItems. (ToolBarItems create a strong dependency therefore the ViewController of the NavigationPage must be explicitly disposed)
Description of Change
disposing viewcontroller in RemovePage.
Platforms Affected
Testing Procedure
PR Checklist