[Xaml] support non-int enums #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
force-pushed
the
xamlc-nonIntEnums
branch
from
10b7f70
to
4985b54
Compare
StephaneDelcroix
added a commit
that referenced
this pull request
Dec 1, 2016
jonathanpeppers
pushed a commit
to Hitcents/Xamarin.Forms
that referenced
this pull request
Jan 26, 2017
This reverts commit 6802739.
mattleibow
added a commit
that referenced
this pull request
Jan 28, 2021
- enum names - compas low pass filter is now a param - updated docs - public constructors on data and events - stating an already started sensor will throw - sensor use the same units on all platforms Added a unit conversion API. #575
mattleibow
added a commit
that referenced
this pull request
Jan 28, 2021
* Rename AppInfo.OpenSettings -> ShowSettingsUI Fixes #567 * Missed one docs rename * Added back a missing using. * Fixed up Clipboard API! Updated everything SetTextAsync. Update xunit test runners * Updates Connectivity APIs from the review! got rid of Other made it unknown, removed WiMAX and updated Profiles to ConnectionProfiles * Change MapKey to Platform.MapServiceToken only for UWP * Dropping the version of the device runner until we can figure out what is broken on UWP (#596) * Update docs/en/FrameworksIndex/xamarin-essentials-uwp.xml Co-Authored-By: jamesmontemagno <james.montemagno@gmail.com> * Fix spacing * Updated DOCS! * Added Default and set it to Medium * [Platform] Remove the Platform for .net standard since it does nothing (#592) - closes #579 * GH-583: [api-fix] Power / Battery (#591) * Move the `Power` members into `Battery` Closes #583 * [Battery] If the charge can be determined, return 1.0 - if the device is on, then it must have some charge - chances are, the issue is that there is no battery at all (on power) - closes #583 * Merged the PR * GH-568: [api-fix] Browser (#589) * OpenAsync returns Task<bool> Also on iOS we can take advantage of some async methods like PresentViewControllerAsync now. * Update API docs * Update Browser.shared.cs * re-gen docs * Generated docs * Revert this to avoid conflicts * Add in DeviceIdiom and DevicePlatform * Updated the docs and added a .gitattributes to control the line endings * Renamed SpeakSettings to SpeechOptions. Closes #580 * Add docs about HTML emails not supported on UWP. Closes #578 * [Map] Fixed the type names and enum values. Closes #576 * Refactor display info and keep screen on. * Add device display. * Change to BatteryInfoChanged and BatteryInfoChangedEventArgs * Revert back battery intent * If we can't unwrap the key, then tear down everything and start over again. * Change back to "DisplayInfoChangedEventArgs" * Update Battery.android.cs * change to valid key * Update Battery.android.cs * Add docs * Rename file correctly for docs! * Cleanup docs * Catch only specific exceptions. some code cleanup * Updated the sensors to adhere to guidelines. #582 - enum names - compas low pass filter is now a param - updated docs - public constructors on data and events - stating an already started sensor will throw - sensor use the same units on all platforms Added a unit conversion API. #575 * Catch invalid key exception. * If there is no main window, then there is no UI thread. Closes 510 * Fixes #612 We shouldn't have a need for telephony as we don't check it on others and restricts VOIP apps. * Integrate html option into sample for email. (#623) * Add Unknown to DeviceType. Update .net standard to return unknown for platform/idiom/type (#627) * Update nugetreadme.txt (#625)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When we did the change to compile the enums, vs parsing them at runtime, we thought that supporting int-based enums was enough. The rationale behind this ? Well, except for interrop or maybe serialization, there's no real reason to use other than ints enums.
Bugs Fixed
PR Checklist