Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xaml] support non-int enums #575

Merged
merged 1 commit into from Dec 1, 2016

Conversation

@StephaneDelcroix
Copy link
Member

commented Nov 29, 2016

Description of Change

When we did the change to compile the enums, vs parsing them at runtime, we thought that supporting int-based enums was enough. The rationale behind this ? Well, except for interrop or maybe serialization, there's no real reason to use other than ints enums.

Bugs Fixed

  • the one @jonathanpeppers reported to me by email. No, not this one. The other below. Yeah, THAT is the one I'm speaking about.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@StephaneDelcroix StephaneDelcroix force-pushed the xamlc-nonIntEnums branch from 10b7f70 to 4985b54 Dec 1, 2016

@StephaneDelcroix StephaneDelcroix merged commit 00b652c into master Dec 1, 2016

1 check failed

Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests failed: 1, passed: 3604, ignored: 10
Details

@StephaneDelcroix StephaneDelcroix deleted the xamlc-nonIntEnums branch Dec 1, 2016

StephaneDelcroix added a commit that referenced this pull request Dec 1, 2016
jonathanpeppers pushed a commit to Hitcents/Xamarin.Forms that referenced this pull request Jan 26, 2017

@samhouts samhouts modified the milestones: 2.3.4, 2.3.3 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.