-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Android] Fix previewer exceptions with shell #5955
Conversation
Xamarin.Forms.Platform.Android/Renderers/ShellFlyoutTemplatedContentRenderer.cs
Show resolved
Hide resolved
@garuma the other area I'm not sure about is how to use a FragmentManager when running as designer the context type provided from designer is
Shell/TabbedPage/MDP all retrieve the SupportFragmentManager from the ACtivity
and that's how they load the content but I don't have a fragment activity when executing under the context of designer. Is there another approach we can take that's designer friendly? |
b003a78
to
b1fde66
Compare
Alright this PR gets rid of all the exceptions with shell and previewer but it's still displaying a blank page most likely because of these errors
I'm thinking we need to either theme wrap our controls when using previewer or previewer needs to use an appcompat theme for now we can at least review and merge this PR into 4.0.0 to fix the exceptions |
Once I activated the appcompat theme for this previewer started throwing a whole new set of exceptions so I set this to DNM for now |
e764a8c
to
481c8f0
Compare
481c8f0
to
0b91344
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm--one line to look at though.
Description of Change
This is a WIP but its purpose was to get through all the Forms SDK exceptions to the point where the previewer would just run shell or not
Current exception coming from previewer
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist