Profiler Proof of Concept #6149
Conversation
|
Can we have a better description on the PR @kingces95 ? |
|
|
||
| #if NETSTANDARD2_0 | ||
| object[] styleAttributes = assembly.GetCustomAttributes(typeof(StyleSheets.StylePropertyAttribute), true); | ||
| object[] styleAttributes = assembly.GetCustomAttributes(typeof(StylePropertyAttribute), true); | ||
| #else | ||
| object[] styleAttributes = assembly.GetCustomAttributes(typeof(StyleSheets.StylePropertyAttribute)).ToArray(); |
There was a problem hiding this comment.
A small detail, after adding the namespace, StyleSheets is no longer necessary here.
object[] styleAttributes = assembly.GetCustomAttributes(typeof(StylePropertyAttribute)).ToArray();
| Registered.Register(attribute.HandlerType, attribute.TargetType, attribute.SupportedVisuals); | ||
| } | ||
| var handlerAttributes = new HandlerAttribute[attributes.Length]; | ||
| Array.Copy(attributes, handlerAttributes, attributes.Length); |
|
This change will not result in dramatic performance improvements. Instead, it was used to demonstrate the feasibility of building our own Forms specific profiler and using that profiler to both identify a performance issue and verify the issue is fixed by a PR. I plan to rename some of the items published in this PR (if I can get away with that) when I push the other performance fixes that, taken together, will produce a startup performance improvement worth promoting. Those fixes are been developed and are now going through our PR process. |
kingces95
changed the title
This change will not result in dramatic performance improvements. Instead, it was used to demonstrate the feasibility of building our own Forms specific profiler and using that profiler to both identify a performance issue and verify the issue is fixed by a PR.
I plan to rename some of the items published in this PR (if I can get away with that) when I push the other performance fixes that, taken together, will produce a startup performance improvement worth promoting.
Those fixes are been developed and are now going through our PR process.
Until all the changes have been submitted it's not worth customers flip any of the flags. Please wait until all the flab has been squeezed out and all flags are defined before taking advantage of any of this work.