Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Unhook Page from embedded Application on disposal #6735

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Jul 1, 2019

Description of Change

Unhook Page from embedded Application on disposal so the Page can be collected.

This is a supplementary fix to #6636; that change allowed Pages which were not hooked to the current Application object to be collected, but did not allow the most recent Page associated with the Application to be collected. This change allows the most recent page to be collected.

Issues Resolved

API Changes

Application.cs

Added:
protected internal virtual void CleanUp();

Modified:
public NavigationProxy NavigationProxy { get; } => public NavigationProxy NavigationProxy { get; private set; }

Platforms Affected

  • Core/XAML (all platforms)
  • iOS

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

Xamarin.Forms.Core/Application.cs Outdated Show resolved Hide resolved
@samhouts samhouts added the API-change Heads-up to reviewers that this PR may contain an API change label Jul 2, 2019
@samhouts samhouts merged commit 22f3954 into 4.1.0 Jul 3, 2019
@samhouts samhouts deleted the ios-embedding-leak branch July 3, 2019 23:46
@samhouts samhouts added this to the 4.1.0 milestone Jul 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/embedding 📦 API-change Heads-up to reviewers that this PR may contain an API change p/iOS 🍎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants