This repository has been archived by the owner on May 1, 2024. It is now read-only.
Unhook Page from embedded Application on disposal #6735
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Unhook Page from embedded Application on disposal so the Page can be collected.
This is a supplementary fix to #6636; that change allowed Pages which were not hooked to the current Application object to be collected, but did not allow the most recent Page associated with the Application to be collected. This change allows the most recent page to be collected.
Issues Resolved
API Changes
Application.cs
Added:
protected internal virtual void CleanUp();
Modified:
public NavigationProxy NavigationProxy { get; }
=>public NavigationProxy NavigationProxy { get; private set; }
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
PR Checklist