New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for disposed gesture detector on VisualElementRenderer #706

Merged
merged 1 commit into from Jan 24, 2017

Conversation

Projects
None yet
5 participants
@hartez
Member

hartez commented Jan 23, 2017

Description of Change

Gestures on view cells which are in the process of being destroyed (e.g., if the ListView's underlying data source is being replaced) can end up in a race condition where the underlying Android gesture detector is already disposed before they are handled. This change adds a check for this condition to avoid a crash.

No UI tests for this; the timing on simulated gestures isn't accurate enough to consistently reproduce this issue.

Bugs Fixed

API Changes

  • None

Behavioral Changes

  • None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@rmarinho rmarinho merged commit 4b19d49 into master Jan 24, 2017

5 of 6 checks passed

iOS10-UITests-C8 Started TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10
Details
Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 352, i…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3697, ignored: 10
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests passed: 346…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 348…
Details

samhouts added a commit that referenced this pull request Feb 24, 2017

@hartez hartez deleted the fix-bugzilla45330 branch May 16, 2017

@samhouts samhouts added D15.4 and removed cla-already-signed labels Oct 10, 2017

@samhouts samhouts added this to the 2.5.0 milestone May 5, 2018

@samhouts samhouts modified the milestones: 2.5.0, 2.3.0, 2.3.3 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment