This repository has been archived by the owner on May 1, 2024. It is now read-only.
Add check for disposed gesture detector on VisualElementRenderer #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
approved these changes
Jan 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Gestures on view cells which are in the process of being destroyed (e.g., if the ListView's underlying data source is being replaced) can end up in a race condition where the underlying Android gesture detector is already disposed before they are handled. This change adds a check for this condition to avoid a crash.
No UI tests for this; the timing on simulated gestures isn't accurate enough to consistently reproduce this issue.
Bugs Fixed
API Changes
Behavioral Changes
PR Checklist