This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Android] Leave BindingContext intact when recycling TemplatedItemViewHolder #7426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed tests are the known CarouselView test failures - unrelated to this PR. |
jfversluis
approved these changes
Sep 10, 2019
rmarinho
approved these changes
Sep 11, 2019
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
TemplatedItemViewHolder is setting the BindingContext of its View to
nullwhen recycling. This causes the template to update and invalidate, which hurts performance and leads to a race condition with measurement where the layout is measured as if it had empty string content and then laid out incorrectly. (For fast Label renderers; for the legacy Label renderers, the layout eventually displays correctly, but the control flashes blank briefly first).This change eliminates the unnecessary re-binding to
nulland avoids the race condition.Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Manual test 6889 in Control Gallery
PR Checklist