This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Android] Refactor the code for setting reverse layout in ItemsViewRenderer #7468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hartez Can you compare the commits in this PR and let us know if the first one makes sense? I know there is some bitwise stuff in the extension methods. |
hartez
approved these changes
Sep 13, 2019
|
UI Test failures are unrelated to these changes. |
jfversluis
approved these changes
Sep 17, 2019
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
…nderer (xamarin#7468) * refactor * fix * remove the return keyword
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
…nderer (xamarin#7468) * refactor * fix * remove the return keyword
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactoring attempt to simplify reverse layout setting so that the code is more readable.