Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[X] do not fail on generic aBP #7588

Merged
merged 1 commit into from
Sep 19, 2019
Merged

[X] do not fail on generic aBP #7588

merged 1 commit into from
Sep 19, 2019

Conversation

StephaneDelcroix
Copy link
Member

@StephaneDelcroix StephaneDelcroix commented Sep 19, 2019

Description of Change

While looking for a potential TypeConverter attribute on the static getter of a
generic attached BP, resolve the generic return type.

Issues Resolved

API Changes

None

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@StephaneDelcroix StephaneDelcroix changed the title [X] do not fail on generic BP [X] do not fail on generic aBP Sep 19, 2019
@samhouts samhouts added a/Xaml </> i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often t/bug 🐛 labels Sep 19, 2019
While looking for a potential TypeConverter attribute on the static getter of a
generic attached BP, resolve the generic return type.

- fixes #7559
@StephaneDelcroix StephaneDelcroix merged commit 1f5f934 into 4.3.0 Sep 19, 2019
@StephaneDelcroix StephaneDelcroix deleted the fix-gh7559 branch September 19, 2019 13:58
@samhouts samhouts added this to the 4.3.0 milestone Oct 1, 2019
felipebaltazar pushed a commit to felipebaltazar/Xamarin.Forms that referenced this pull request Oct 16, 2019
While looking for a potential TypeConverter attribute on the static getter of a
generic attached BP, resolve the generic return type.

- fixes xamarin#7559
felipebaltazar pushed a commit to felipebaltazar/Xamarin.Forms that referenced this pull request Oct 16, 2019
While looking for a potential TypeConverter attribute on the static getter of a
generic attached BP, resolve the generic return type.

- fixes xamarin#7559
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/Xaml </> i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often t/bug 🐛
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants