Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[UWP] Adjust AutoSuggestBox's TextBoxStyle style name to prevent possible crash #774

Merged
merged 1 commit into from
Mar 7, 2017

Conversation

pauldipietro
Copy link
Contributor

@pauldipietro pauldipietro commented Feb 16, 2017

Description of Change

Presently trying to set the AutoSuggestBox style like the following for UWP causes a crash:

<Style TargetType="AutoSuggestBox">
    <Setter Property="FontFamily" Value="Comic Sans MS"/>
</Style>

Although setting this property in a native UWP app would not work (the style should be applied as a value on TextBoxStyle), it wouldn't crash. The crash here appears due to a naming conflict on the AutoSuggestBoxTextBoxStyle key being used; renaming this appears to prevent this crash from occurring. The App.xaml in the UWP gallery project was not modified for this PR to keep global styles the same, but would reproduce the issue if added.

Bugs Fixed

https://bugzilla.xamarin.com/show_bug.cgi?id=41919

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@rmarinho rmarinho merged commit 98fe880 into master Mar 7, 2017
@rmarinho rmarinho deleted the fix-bugzilla41919 branch June 22, 2017 10:52
@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants