New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UWP] Adjust AutoSuggestBox's TextBoxStyle style name to prevent possible crash #774

Merged
merged 1 commit into from Mar 7, 2017

Conversation

Projects
None yet
4 participants
@pauldipietro
Member

pauldipietro commented Feb 16, 2017

Description of Change

Presently trying to set the AutoSuggestBox style like the following for UWP causes a crash:

<Style TargetType="AutoSuggestBox">
    <Setter Property="FontFamily" Value="Comic Sans MS"/>
</Style>

Although setting this property in a native UWP app would not work (the style should be applied as a value on TextBoxStyle), it wouldn't crash. The crash here appears due to a naming conflict on the AutoSuggestBoxTextBoxStyle key being used; renaming this appears to prevent this crash from occurring. The App.xaml in the UWP gallery project was not modified for this PR to keep global styles the same, but would reproduce the issue if added.

Bugs Fixed

https://bugzilla.xamarin.com/show_bug.cgi?id=41919

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@rmarinho rmarinho merged commit 98fe880 into master Mar 7, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Running
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3742, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Running
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Running
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Running
Details

@rmarinho rmarinho deleted the fix-bugzilla41919 branch Jun 22, 2017

@samhouts samhouts added D-15.4 and removed cla-not-required labels Oct 10, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment