[iOS] Prevent "NaN is not a valid value for width" exception #776

Merged
merged 2 commits into from Feb 21, 2017

Conversation

Projects
None yet
5 participants
@samhouts
Member

samhouts commented Feb 18, 2017

Description of Change

Fix regression introduced in #529 allowing an infinite width to be returned for `Label's on iOS, which led to an exception in nested and potentially horizontally infinite layouts.

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

samhouts added some commits Feb 18, 2017

@rmarinho rmarinho merged commit 8c457a0 into master Feb 21, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 353, i…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3743, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests passed: 35…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests passed: 351…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 353…
Details

@rmarinho rmarinho deleted the fix-bugzilla52533 branch Feb 21, 2017

@rooby

This comment has been minimized.

Show comment
Hide comment
@rooby

rooby Feb 27, 2017

This is a fairly intrusive bug, does anyone know when the next release is scheduled?

rooby commented Feb 27, 2017

This is a fairly intrusive bug, does anyone know when the next release is scheduled?

@samhouts samhouts added this to the 2.3.5 milestone Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment