This repository has been archived by the owner on May 1, 2024. It is now read-only.
Generics for CollectionView iOS implementation #7918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartez
force-pushed
the
cv-ios-generic
branch
from
2c359de
to
88f5ab3
Compare
samhouts
added
the
blocker
StephaneDelcroix
approved these changes
Oct 10, 2019
samhouts
approved these changes
Oct 10, 2019
samhouts
added
the
approved
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
* Make the ItemsView type generic * Make controller type generic * Generic all the things, and split up the delegators Fix rebase error
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
* Make the ItemsView type generic * Make controller type generic * Generic all the things, and split up the delegators Fix rebase error
CliffAgius
pushed a commit
to CliffAgius/Xamarin.Forms
that referenced
this pull request
Dec 6, 2019
* Make the ItemsView type generic * Make controller type generic * Generic all the things, and split up the delegators Fix rebase error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
These changes move the CollectionView iOS implementation from casting controllers, delegators, and view classes at runtime to using generics.
These changes also split up the delegator classes to make them more readable and maintainable.
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
PR Checklist