Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix Issue 8207 | [Bug] Shell Flyout Items on UWP aren't showing the Title #8248

Merged
merged 6 commits into from
Dec 16, 2019

Conversation

felipebaltazar
Copy link
Contributor

Description of Change

I've create an override to SelectTemplateCore(object item, DependencyObject container)

Issues Resolved

API Changes

Added to Xamarin.Forms.Platform.UWP.ShellFlyoutTemplateSelector:

  • Windows.UI.Xaml.DataTemplate SelectTemplateCore(object item, DependencyObject container)

Platforms Affected

  • UWP

Behavioral/Visual Changes

FlyoutItems will show title and icons when it setted

Before/After Screenshots

  • Before

image

  • After

image

Testing Procedure

  1. Create Xamarin Forms Shell Template
  2. Add some flyout items
  3. Add and run UWP platform

Or just run the Issue8207 test from Control Gallery

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@felipebaltazar
Copy link
Contributor Author

Hello!

How can I create, from C# code, a layout like this:

image

I'm trying to write some tests for these scenarios, but I founded only Xaml examples

@jfversluis
Copy link
Member

jfversluis commented Oct 30, 2019

Is there any specific reason you want to do it in code @felipebaltazar ? You should be able to use XAML in your issue page. See other examples like Issue4684.

Of course you should also be able to do it in code. You can find some examples of that in other issue pages as well.

@felipebaltazar
Copy link
Contributor Author

Is there any specific reason you want to do it in code @felipebaltazar ? You should be able to use XAML in your issue page. See other examples like Issue4684.

Of course you should also be able to do it in code. You can find some examples of that in other issue pages as well.

@jfversluis This is true! I went through some problems the first time I tried to create a Xaml-based UITest ..
But in other PRs that I created (in this repository), I managed to solve them ... I will recreate this problem test in Xaml.

@felipebaltazar
Copy link
Contributor Author

I've updated the issue class and added a UI test

@felipebaltazar
Copy link
Contributor Author

@rmarinho @samhouts Any position about this PR? Failing tests seems like not related

@felipebaltazar
Copy link
Contributor Author

I've updated this branch, can we merge this?

@felipebaltazar
Copy link
Contributor Author

@rmarinho @samhouts Any position about this PR ?

@samhouts samhouts changed the base branch from 4.3.0 to 4.4.0 December 16, 2019 23:38
@samhouts samhouts merged commit 4fe5fbf into xamarin:4.4.0 Dec 16, 2019
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Dec 16, 2019
@samhouts samhouts added this to the 4.4.0 milestone Jan 7, 2020
@felipebaltazar felipebaltazar deleted the issues/8207 branch February 1, 2020 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/shell 🐚 approved Has two approvals, no pending reviews, and no changes requested hacktoberfest 🍻 p/UWP t/bug 🐛
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants