Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

fix 54730 #874

Merged
merged 1 commit into from
May 4, 2017
Merged

fix 54730 #874

merged 1 commit into from
May 4, 2017

Conversation

kingces95
Copy link
Contributor

@kingces95 kingces95 commented Apr 18, 2017

Description of Change

Allow Span to have null value by replacing null with empty string before rendering the span.

Bugs Fixed

https://bugzilla.xamarin.com/show_bug.cgi?id=54730

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

Copy link
Member

@StephaneDelcroix StephaneDelcroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it working as expected on other plats ? Could you add a UITest ?

Otherwise 👍

@rmarinho rmarinho merged commit b26d9ec into master May 4, 2017
@rmarinho rmarinho deleted the bz54730 branch May 4, 2017 15:32
@samhouts samhouts added this to the 2.4.0 milestone Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants