This repository has been archived by the owner on May 1, 2024. It is now read-only.
[UWP] Use transparent as default TabbedPage bar background color #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this might break behavior when not inside a nav page? |
|
@pauldipietro This might break if the Tabbed Page is inside of a Navigation Page - can you write a separate test with that scenario? |
|
@pauldipietro Please see comments. Thanks! :) |
pauldipietro
force-pushed
the
fix-bugzilla55674
branch
2 times, most recently
from
9fe2c36
to
83b875c
Compare
|
@pauldipietro We still need a test for a TabbedPage inside of a NavigationPage, when you've got time to come back to this. Thanks! |
pauldipietro
commented
Nov 7, 2017
| } | ||
| }); | ||
|
|
||
| Children.Add(new NavigationPage(tabbedPage)); |
There was a problem hiding this comment.
I believe I had force pushed this addition here if you get a chance to check it out.
There was a problem hiding this comment.
Excellent! While you're rebasing, can you put together some before/after screenshots for us? Thanks!!
|
Can you rebase please @pauldipietro ? |
pauldipietro
force-pushed
the
fix-bugzilla55674
branch
from
83b875c
to
caff1fd
Compare
|
@pauldipietro can you open a new pr for this, no need for WINDOWS_UWP now. |
4 tasks
rmarinho
pushed a commit
that referenced
this pull request
Jan 11, 2018
…reopen) (#1327) * [UWP] Use transparent as default TabbedPage bar background color * Remove a now unnecessary check for 8.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When navigating between tabs that change the BarBackgroundColor, returning to a tab where the value would be the default would use the value of
SystemControlBackgroundChromeMediumLowBrushrather than transparent which is what UWP uses (see the style here for reference, inside of thePivotPanel).Bugs Fixed
https://bugzilla.xamarin.com/show_bug.cgi?id=55674
API Changes
None
Behavioral Changes
None
PR Checklist