This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Bug] macOS: 4.4->4.5 regression, labels are invisible (same TextColor as background) #9589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So it seems the regression was introduced in here: 610dde4 |
samhouts
added
the
retarget-branch-required
|
@samhouts should I retarget branch to different from master? |
|
@AndreiMisiukevich yes 4.5.0 |
AndreiMisiukevich
force-pushed
the
fix_9526
branch
from
76188c8
to
0423799
Compare
|
@rmarinho done |
rmarinho
approved these changes
Feb 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixed regression bug on Mac OS. Default color is not converted to Black for macOs.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
Default text color of Labels on Mac became BLACK instead of transparent.
Testing Procedure
Create a content page with a label inside. Run the sample on MacOs. See that label is invisible.