[Android/iOS] Swipe to close in SwipeView

[jsuarezruiz]

Description of Change

In this PR we fix several issues related to the swipe gesture in SwipeView:

• Allow swipe to close SwipeItems.
• Allow to move from one open SwipeItem to another doing swipe.
• Invalid touch in SwipeItems closing the SwipeView.

Issues Resolved

• fixes [Bug] [iOS] Cannot un-reveal swipe view items on iOS / Inconsistent swipe view behaviour #9306
• fixes [Enhancement] SwipeView Pull To Close #9461
• fixes [Bug] SwipeView in 4.5 works only first way swipped #9734
• fixes [Bug][iOS] SwipeView SwipeBehaviorOnInvoked RemainOpen issue on iOS #8767
• fixes [Bug] SwipeViewItem handler invocation intermittent issue on iOS and Android #8778
• fixes [Bug] SwipeView - bad responsiveness to touch #8983

API Changes

None

Platforms Affected

• iOS
• Android

Behavioral/Visual Changes

None

Before/After Screenshots

Before

Realize that to close the SwipeView the tap works but not the swipe. In a similar way, trying to move from the left open SwipeItem to the right one was not possible without previously closing the SwipeView.

After

Android

iOS

Testing Procedure

PR Checklist

• Targets the correct branch
• Tests are passing (or failures are unrelated)

[jfversluis]

Build errors :(

##[error]Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Issue8781.xaml.cs(42,5): Error CS0103: The name 'resultEntry' does not exist in the current context

I think you need to do some #if APP like suggested

[jfversluis]

##[error]Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Issue8781.xaml.cs(37,14): Error CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

[vniehues]

In Previous versions the SwipeView was preventing underlying TapGestureRecognizers from working;
e.g. You have a list with swipeViews but you also want to open a detail page using a simple tap. that tap didn't come through.

Is that fixed as well? Or should I open a new issue for that one?

[jsuarezruiz]

@vniehues Could you take a look to this PR #9638?, do you mean the selection events?. In that PR we added tests using ListView, CollectionView events and also using GestureRecognizer.

[vniehues]

@jsuarezruiz In the PR and the gif you showed it looks like my issue will be resolved.

Just to clarify, I don't mean the built-in selection event. In my case I added a TapGestureRecognizer to the ItemTemplates first child (StackLayout in this case) but the TapGestureRecognizer did not get the Input. At least it didn't call the specified command (which it did before adding the SwipeView).

Do I have to add the TapGestureRecognizer to the SwipeView or its Content (e.g. StackLayout)?

[PureWeen]

Nice! would it be possible to add some UI Tests? Especially for the swiping back and forth scenarios?

That swipe to reveal and entry with a math question is awesome!!

[jfversluis]

A UI Test is always a good idea! So maybe add that, but this looks good to go so merge at will or add the test and merge then ;)

[jsuarezruiz]

Thanks for the feedback! I have added more samples and UITests to verify the SwipView opening and closing by doing swipe.