Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[WPF] Dont set Slider.Value if it already matches control #9847

Merged
merged 1 commit into from
Mar 8, 2020

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Mar 4, 2020

Description of Change

If you get into a scenario where a set bindable property is queue'd up internally it will cause the Slider to hit an infinite loop. The BP will set the value which then causes the Control to get set, which was then causing a value to get set from the renderer to the element, which would then get queue'd up, etc...

Platforms Affected

  • WPF

Testing Procedure

  • make sure sliders all still work on WPF
  • The place I Was seeing this issue was on the TwoPaneView gallery. On the properties gallery if you set both of the MinTall and MinWide values to max then resized the window

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added the p/WPF label Mar 4, 2020
@PureWeen PureWeen added this to the 4.5.0 milestone Mar 4, 2020
@rmarinho rmarinho merged commit 7a69842 into 4.5.0 Mar 8, 2020
@samhouts samhouts deleted the fix_wpf_slider branch June 26, 2020 00:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants