This repository has been archived by the owner on May 1, 2024. It is now read-only.
Update the status bar frame when rotating #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am happy to target |
|
Yeah just target main for now for everything as we're not really doing any parallel versions atm :) also there seems to be an error while building here? |
OK I will retarget thanks. As for the build error I am not convinced it is something I have introduced. Looking at the pipeline results it suggests that a unit test failed:
|
bijington
force-pushed
the
feature/issue-1638-status-bar-rotation-ios
branch
from
b681a20
to
616ec1a
Compare
|
@jfversluis this is now targeting |
jfversluis
approved these changes
Oct 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Bug
Issues Fixed
Behavioral Changes
PR Checklist
approved