[Bug] Invalid Resources generated for DesignTime #3007

NPadrutt · 2019-04-15T10:19:23Z

Description

With Version 3.5.x of Xamarin Forms I have a lot of errors all regarding the Resource.Designer in the obj-Debug-[Version]-designtime folder.
I experimented around with the target and minimum Android SDK Version but had it with both 9.0 and 8.1.

(since I was no able to get the errors in an output, I add a Screenshot here)

It seems that this is caused by entries like:

		// aapt resource value: 0x7F010174
		public const int bottomtab.navarea = 2130772340;
		
		// aapt resource value: 0x7F010175
		public const int bottomtab.tabbar = 2130772341;

Also these do not exist in the Resource.Designer used to build the app.
I tried deleting all the bin and obj folders, but the file is always regenerated with the same entries.

Steps to Reproduce

Open a solution in either VS 2019 or 2017 with Xamarin Forms >= 3.5 in the project.

Expected Behavior

No Errors.

Actual Behavior

Error messages appear.

Basic Information

Version with issue:
Last known good version: 3.4.0.1039999
IDE: Visual Studio 2017 / 2019
Platform Target Frameworks:
- iOS:
- Android: 8.1, 9
- UWP:
Android Support Library Version:
Nuget Packages:
Affected Devices:

Screenshots

Reproduction Link

App1.zip

The text was updated successfully, but these errors were encountered:

pjcollins · 2019-04-22T20:21:04Z

I was able to reproduce some resolution issues when loading this project "untouched" in VS2017/2019, but deleting the included bin and obj folders and allowing a fresh NuGet restore to complete did put me back in a working state. There seems to be a potential bin/obj and NuGet related issue that could be investigated further using the attached project. However, I didn't encounter any Resource.designer.cs related errors after changing target framework versions or playing around with this project in VS2017 and VS2019.

NPadrutt · 2019-04-22T20:47:22Z

@pjcollins Thanks for your feedback. Have you restartet VS after you where able to build? What I observed is the Designer file recreated on a restart.

jonathanpeppers · 2019-04-23T13:27:42Z

I think I can reproduce it command-line (I deleted bin/obj directories first):

# Build the netstandard project
> msbuild .\App1\App1\App1.csproj /restore
# Simulate a design-time build that would happen in the IDE
> msbuild .\App1\App1.Android\App1.Android.csproj /restore /t:Compile /p:DesignTimeBuild=True /p:BuildingInsideVisualStudio=True

This was VS 2019 GA.

Got a bunch of errors like:

  obj\Debug\81\designtime\Resource.designer.cs(5048,21,5048,30): error CS0145: A const field requires a value to be provided [C:\Users\jopepper\Downloads\App1 (5)\App1\App1\App1.Android\App1.Android.csproj]
  obj\Debug\81\designtime\Resource.designer.cs(5048,30,5048,31): error CS1003: Syntax error, ',' expected [C:\Users\jopepper\Downloads\App1 (5)\App1\App1\App1.Android\App1.Android.csproj]
  obj\Debug\81\designtime\Resource.designer.cs(5048,31,5048,38): error CS1002: ; expected [C:\Users\jopepper\Downloads\App1 (5)\App1\App1\App1.Android\App1.Android.csproj]

Will see if this happens with xamarin-android/master.

jonathanpeppers · 2019-04-23T14:55:28Z

So it looks like master is working, but with lots of warnings:

# There were ~2,000 of these!
Xamarin.Android.Common.targets(1332,2): warning XA0106: Skipping App1.Droid.Resource.Styleable.ViewStubCompat_android_layout. Please check that your Nuget Package versions are compatible.

I need to figure out where the problem is here, it seems we have duplicate resources in some of the support library NuGets?

It looks like the problem with the C# compiler error was fixed in: 752a25f Duplicates are now warnings, why are there so many?

SebastianKruseWago · 2019-04-24T09:09:49Z

@jonathanpeppers This issue is also reported on other places, see:

https://developercommunity.visualstudio.com/content/problem/461522/new-android-project-in-vs2019-preview-errors-on-pu.html

https://stackoverflow.com/questions/55137449/xamarin-forms-generates-wrong-ressources

https://stackoverflow.com/questions/55809011/xamarin-droid-resource-designer-cs-is-generated-in-a-strange-way

dellis1972 · 2019-04-25T10:47:27Z

This looks related to this change https://github.com/xamarin/Xamarin.Forms/blob/master/Xamarin.Forms.Platform.Android/Resources/Layout/BottomTabLayout.axml#L13.

Xamarin.Forms is using android:id="@+id/bottomtab.tabbar". It seems the ManagedResourceParser is NOT fixing up android id values with contain a ..

It should be producing public const int toolbar_one = 2131230899; not public const int toolbar.one = 2131230899;

There might be a way to work around this but it will come at a design time build performance cost. You can set the AndroidUseManagedDesignTimeResourceGenerator to False in your csproj. This will mean the design time build will fall back on the old aapt based generator (which is slower), but it should work.

Place the following in the first PropertyGroup if the Android csproj.

<AndroidUseManagedDesignTimeResourceGenerator>False</AndroidUseManagedDesignTimeResourceGenerator>

SebastianKruseWago · 2019-04-25T11:19:52Z

@dellis1972 Seems to solve the issue but what did you mean with this?

it will come at a design time build performance cost

Do you mean the very aweful Xamarin.Forms Previewer? Or the Android native "designer" which is also average at best?

dellis1972 · 2019-04-25T12:54:20Z

The Design Time Build is what Visual Studio does in the background to generate code completion and intellisense. Normally this build should run very quickly, this is one of the reasons the ManagedResourceParser exists. Aapt however can be very slow, especially on projects with allot of resources. So disabling the ManagedResourceParser might mean the IDE becomes a bit sluggish when a Design Time Build is running, this is normally when you save a axml layout file you are working on.

I'm working on a fix for the ManagedResourceParser now.

Fixes xamarin#3007 Xamarin.Forms introduced some new `android:id` values in the `Xamarin.Forms.Platform.Android` assembly [1]. These include a period `.` in the identifier, such as android:id="@+id/bottomtab.tabbar" android:id="@+id/toolbar.one" When processing these with `aapt` or `aapt2` these identifiers are "fixed up" to be valid java identifiers. The same is NOT true for the `ManagedResourceParser`. As a result the very first design time build will fail with the following error. obj\Debug\81\designtime\Resource.designer.cs(5048,21,5048,30): error CS0145: A const field requires a value to be provided obj\Debug\81\designtime\Resource.designer.cs(5048,30,5048,31): error CS1003: Syntax error, ',' obj\Debug\81\designtime\Resource.designer.cs(5048,31,5048,38): error CS1002: ; expected This is because it is generating the following code in the `Resource.designer.cs` public const int toolbar.one = 2131230899; which is NOT a valid C# identifier. This commit reworks the parser to use the `CodeDomProvider.CreateValidIdentifier` method to create a valid c# identifier from the name passed in. However.. it turns out that `CodeDomProvider.CreateValidIdentifier` thinks that a `.` is a valid identifier character. This is despite `CodeDomProvider.IsValidIdentifier` returning `false` for that value... So lets ALSO do a string replace '.' for '_' as well. I also updated the unit test to test for this senario. [1] https://github.com/xamarin/Xamarin.Forms/blob/master/Xamarin.Forms.Platform.Android/Resources/Layout/BottomTabLayout.axml#L13.

Fixes xamarin#3007 Xamarin.Forms introduced some new `android:id` values in the `Xamarin.Forms.Platform.Android` assembly [1]. These include a period `.` in the identifier, such as android:id="@+id/bottomtab.tabbar" android:id="@+id/toolbar.one" When processing these with `aapt` or `aapt2` these identifiers are "fixed up" to be valid java identifiers. The same is NOT true for the `ManagedResourceParser`. As a result the very first design time build will fail with the following error. obj\Debug\81\designtime\Resource.designer.cs(5048,21,5048,30): error CS0145: A const field requires a value to be provided obj\Debug\81\designtime\Resource.designer.cs(5048,30,5048,31): error CS1003: Syntax error, ',' obj\Debug\81\designtime\Resource.designer.cs(5048,31,5048,38): error CS1002: ; expected This is because it is generating the following code in the `Resource.designer.cs` public const int toolbar.one = 2131230899; which is NOT a valid C# identifier. This commit adds a new `ResourceIdentifier` class which is responsible for making sure the identifier we generate is a valid C# identifier. This logic is based on the C# language specifications [1]. It also does keyword detection and prepends an `@` if required. Just in case a user calls an item `base` or `class` or any other C# keyword. This commit also reworks the id generation of the `ManagedResourceParser` to replicate exactly the ids which `aapt2` produce. As a result if the managed parser generates the code from the `R.txt` file or directly from the resources, the resulting designer.cs file will be IDENTICAL. This should help us reduce some of the calls to `aapt` in the future. [1] https://github.com/xamarin/Xamarin.Forms/blob/master/Xamarin.Forms.Platform.Android/Resources/Layout/BottomTabLayout.axml#L13. [2] https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/language-specification/lexical-structure#identifiers [3] https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/language-specification/lexical-structure#keywords Rework the ManagedResourceParser to produce the same results as R.txt

Fixes xamarin#3007 Xamarin.Forms introduced some new `android:id` values in the `Xamarin.Forms.Platform.Android` assembly [1]. These include a period `.` in the identifier, such as android:id="@+id/bottomtab.tabbar" android:id="@+id/toolbar.one" When processing these with `aapt` or `aapt2` these identifiers are "fixed up" to be valid java identifiers. The same is NOT true for the `ManagedResourceParser`. As a result the very first design time build will fail with the following error. obj\Debug\81\designtime\Resource.designer.cs(5048,21,5048,30): error CS0145: A const field requires a value to be provided obj\Debug\81\designtime\Resource.designer.cs(5048,30,5048,31): error CS1003: Syntax error, ',' obj\Debug\81\designtime\Resource.designer.cs(5048,31,5048,38): error CS1002: ; expected This is because it is generating the following code in the `Resource.designer.cs` public const int toolbar.one = 2131230899; which is NOT a valid C# identifier. This commit adds a new `ResourceIdentifier` class which is responsible for making sure the identifier we generate is a valid C# identifier. This logic is based on the C# language specifications [1]. It also does keyword detection and prepends an `@` if required. Just in case a user calls an item `base` or `class` or any other C# keyword. This commit also reworks the id generation of the `ManagedResourceParser` to replicate exactly the ids which `aapt2` produce. As a result if the managed parser generates the code from the `R.txt` file or directly from the resources, the resulting designer.cs file will be IDENTICAL. This should help us reduce some of the calls to `aapt` in the future. [1] https://github.com/xamarin/Xamarin.Forms/blob/master/Xamarin.Forms.Platform.Android/Resources/Layout/BottomTabLayout.axml#L13. [2] https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/language-specification/lexical-structure#identifiers [3] https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/language-specification/lexical-structure#keywords

Fixes xamarin#3007 Xamarin.Forms introduced some new `android:id` values in the `Xamarin.Forms.Platform.Android` assembly [1]. These include a period `.` in the identifier, such as android:id="@+id/bottomtab.tabbar" android:id="@+id/toolbar.one" When processing these with `aapt` or `aapt2` these identifiers are "fixed up" to be valid java identifiers. The same is NOT true for the `ManagedResourceParser`. As a result the very first design time build will fail with the following error. obj\Debug\81\designtime\Resource.designer.cs(5048,21,5048,30): error CS0145: A const field requires a value to be provided obj\Debug\81\designtime\Resource.designer.cs(5048,30,5048,31): error CS1003: Syntax error, ',' obj\Debug\81\designtime\Resource.designer.cs(5048,31,5048,38): error CS1002: ; expected This is because it is generating the following code in the `Resource.designer.cs` public const int toolbar.one = 2131230899; which is NOT a valid C# identifier. This commit adds a new `ResourceIdentifier` class which is responsible for making sure the identifier we generate is a valid C# identifier. This logic is based on the C# language specifications [1]. It also does keyword detection and prepends an `@` if required. Just in case a user calls an item `base` or `class` or any other C# keyword. [1] https://github.com/xamarin/Xamarin.Forms/blob/master/Xamarin.Forms.Platform.Android/Resources/Layout/BottomTabLayout.axml#L13. [2] https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/language-specification/lexical-structure#identifiers [3] https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/language-specification/lexical-structure#keywords

…ime (#3054) Fixes: #3007 Xamarin.Forms introduced some new `android:id` values in the [`Xamarin.Forms.Platform.Android` assembly][1]. These values include a period `.` in the identifier, such as android:id="@+id/bottomtab.tabbar" android:id="@+id/toolbar.one" When processing these with `aapt` or `aapt2` these identifiers are "fixed up" to be valid Java identifiers, replacing `.` with `_`. The same is NOT true for the `ManagedResourceParser`. As a result the very first design time build will fail with the following error. obj\Debug\81\designtime\Resource.designer.cs(5048,21,5048,30): error CS0145: A const field requires a value to be provided obj\Debug\81\designtime\Resource.designer.cs(5048,30,5048,31): error CS1003: Syntax error, ',' obj\Debug\81\designtime\Resource.designer.cs(5048,31,5048,38): error CS1002: ; expected This is because it is generating the following code in the `Resource.designer.cs` public const int toolbar.one = 2131230899; which is NOT a valid C# identifier. This commit adds a new `ResourceIdentifier` class which is responsible for making sure the identifier we generate is a valid C# identifier. This logic is based on the [C# language specification][1]. It also does keyword detection and prepends an `@` if required, just in case a user calls an item `base` or `class` or any other C# keyword. [1]: https://github.com/xamarin/Xamarin.Forms/blob/master/Xamarin.Forms.Platform.Android/Resources/Layout/BottomTabLayout.axml#L13 [2]: https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/language-specification/lexical-structure#identifiers [3]: https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/language-specification/lexical-structure#keywords

Fixes xamarin#3007 Xamarin.Forms introduced some new `android:id` values in the `Xamarin.Forms.Platform.Android` assembly [1]. These include a period `.` in the identifier, such as android:id="@+id/bottomtab.tabbar" android:id="@+id/toolbar.one" When processing these with `aapt` or `aapt2` these identifiers are "fixed up" to be valid java identifiers. The same is NOT true for the `ManagedResourceParser`. As a result the very first design time build will fail with the following error. obj\Debug\81\designtime\Resource.designer.cs(5048,21,5048,30): error CS0145: A const field requires a value to be provided obj\Debug\81\designtime\Resource.designer.cs(5048,30,5048,31): error CS1003: Syntax error, ',' obj\Debug\81\designtime\Resource.designer.cs(5048,31,5048,38): error CS1002: ; expected This is because it is generating the following code in the `Resource.designer.cs` public const int toolbar.one = 2131230899; which is NOT a valid C# identifier. This commit adds a new `ResourceIdentifier` class which is responsible for making sure the identifier we generate is a valid C# identifier. This logic is based on the C# language specifications [1]. It also does keyword detection and prepends an `@` if required. Just in case a user calls an item `base` or `class` or any other C# keyword. This commit also reworks the id generation of the `ManagedResourceParser` to replicate exactly the ids which `aapt2` produce. As a result if the managed parser generates the code from the `R.txt` file or directly from the resources, the resulting designer.cs file will be IDENTICAL. This should help us reduce some of the calls to `aapt` in the future. [1] https://github.com/xamarin/Xamarin.Forms/blob/master/Xamarin.Forms.Platform.Android/Resources/Layout/BottomTabLayout.axml#L13. [2] https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/language-specification/lexical-structure#identifiers [3] https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/language-specification/lexical-structure#keywords

aherrick · 2019-05-03T15:49:48Z

Just a heads up I'm still seeing this issue on the latest version of VS2019 4.7.03190

Deleting the Resource Designer fixes temporarily, then rebuilding brings it right back.

dellis1972 · 2019-05-03T20:14:49Z

@aherrick you will still see it in the stable release since we just merged this into master, and cherry-picked it to d16-2 (which is the next preview).

aherrick · 2019-05-04T09:07:10Z

@dellis1972 thanks for the update... will keep an eye out.

aherrick · 2019-05-22T13:59:10Z

FYI this still isn't fixed. VS 2019 16.1.0

dellis1972 · 2019-05-22T14:58:07Z

@aherrick the fix was cherry-picked to the 16.2 branch , it should be in Preview 2. I don't think we can back port this to 16.1 . Note the work around for 16.1 is to add

<AndroidUseManagedDesignTimeResourceGenerator>False</AndroidUseManagedDesignTimeResourceGenerator>

to your csproj PropertyGroup

aherrick · 2019-06-04T15:59:57Z

Thanks! The work around solved this for me.

jgold6 · 2019-06-28T18:44:02Z

Can this fix be released for S 2017 as well?

candidodmv · 2019-07-05T16:20:52Z

as said above by @jgold6 , it's very important support vs2017!

dellis1972 · 2019-07-06T11:46:09Z

@jgold6 @candidodmv does the work around not work for VS2017?

jgold6 · 2019-07-08T18:39:40Z

The work around does work for VS 2017. As such I have already been informed by @bholmes that the fix for this will not be backported to VS 2017.

devopsone · 2019-07-09T05:55:58Z

I have 3 computers with the same setup and this only happens on one machine. Anybody knows why? I have to fix it with the workaround but wonder whats different to the other installations. They are totally same, even packages, updates.

dev-thinks · 2021-05-09T04:27:34Z

I am facing this issue still exists in latest VS 2019 version. and works with work around changes in project file.

Is this issue addressed already as it is in closed state now?

Tx

dellis1972 · 2021-05-09T18:59:59Z

@dev-thinks The fix was shipped, you might have hit a different corner case. Can you open a new issue and attach a repo project and/or diagnostic build logs so we can investigate.

samhouts transferred this issue from xamarin/Xamarin.Forms Apr 19, 2019

pjcollins added this to the Under Consideration milestone Apr 22, 2019

pjcollins assigned dellis1972 and jonathanpeppers Apr 22, 2019

pjcollins added Area: App+Library Build Issues when building Library projects or Application projects. Area: Design-Time Build Issues with VS design-time build. labels Apr 22, 2019

dellis1972 mentioned this issue Apr 25, 2019

[Xamarin.Android.Build.Tasks] first styleable resource id is always incorrect #3025

Merged

dellis1972 mentioned this issue Apr 26, 2019

Xamarin Android - New Created Tabbed App crashes after changing newly added ImageView's src attribute in VS2019. #3021

Closed

dellis1972 mentioned this issue May 1, 2019

[Xamarin.Android.Build.Tasks] Invalid Resources generated for DesignTime #3054

Merged

jonpryor closed this as completed in #3054 May 3, 2019

brendanzagaeski modified the milestones: Under Consideration, d16-2 Jun 13, 2019

xamarin locked as resolved and limited conversation to collaborators Jun 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug] Invalid Resources generated for DesignTime #3007

[Bug] Invalid Resources generated for DesignTime #3007

NPadrutt commented Apr 15, 2019

pjcollins commented Apr 22, 2019

NPadrutt commented Apr 22, 2019

jonathanpeppers commented Apr 23, 2019

jonathanpeppers commented Apr 23, 2019

SebastianKruseWago commented Apr 24, 2019

dellis1972 commented Apr 25, 2019

SebastianKruseWago commented Apr 25, 2019

dellis1972 commented Apr 25, 2019

aherrick commented May 3, 2019

dellis1972 commented May 3, 2019

aherrick commented May 4, 2019

aherrick commented May 22, 2019

dellis1972 commented May 22, 2019

aherrick commented Jun 4, 2019

jgold6 commented Jun 28, 2019

candidodmv commented Jul 5, 2019 •

edited

dellis1972 commented Jul 6, 2019

jgold6 commented Jul 8, 2019

devopsone commented Jul 9, 2019

dev-thinks commented May 9, 2021

dellis1972 commented May 9, 2021

[Bug] Invalid Resources generated for DesignTime #3007

[Bug] Invalid Resources generated for DesignTime #3007

Comments

NPadrutt commented Apr 15, 2019

Description

Steps to Reproduce

Expected Behavior

Actual Behavior

Basic Information

Screenshots

Reproduction Link

pjcollins commented Apr 22, 2019

NPadrutt commented Apr 22, 2019

jonathanpeppers commented Apr 23, 2019

jonathanpeppers commented Apr 23, 2019

SebastianKruseWago commented Apr 24, 2019

dellis1972 commented Apr 25, 2019

SebastianKruseWago commented Apr 25, 2019

dellis1972 commented Apr 25, 2019

aherrick commented May 3, 2019

dellis1972 commented May 3, 2019

aherrick commented May 4, 2019

aherrick commented May 22, 2019

dellis1972 commented May 22, 2019

aherrick commented Jun 4, 2019

jgold6 commented Jun 28, 2019

candidodmv commented Jul 5, 2019 • edited

dellis1972 commented Jul 6, 2019

jgold6 commented Jul 8, 2019

devopsone commented Jul 9, 2019

dev-thinks commented May 9, 2021

dellis1972 commented May 9, 2021

candidodmv commented Jul 5, 2019 •

edited