Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[One .NET] $(UseInterpreter) should set DOTNET_MODIFIABLE_ASSEMBLIES=Debug #6016

Closed
jonathanpeppers opened this issue Jun 10, 2021 · 0 comments · Fixed by #6027
Closed

[One .NET] $(UseInterpreter) should set DOTNET_MODIFIABLE_ASSEMBLIES=Debug #6016

jonathanpeppers opened this issue Jun 10, 2021 · 0 comments · Fixed by #6027
Assignees
@jonathanpeppers
Labels
Area: App+Library Build Issues when building Library projects or Application projects.
Milestone
.NET 6

Comments

@jonathanpeppers
Copy link
Member

Context: https://github.com/dotnet/maui/blob/main/src/Templates/src/templates/maui-mobile/MauiApp1/Android/AndroidEnvironment.txt

To enable "Hot Reload", right now you have two steps:

  1. Set $(UseInterpreter) to true
  2. Add an @(AndroidEnvironment) file that sets DOTNET_MODIFIABLE_ASSEMBLIES=Debug

In .NET 6, we should make $(UseInterpreter) set to true setup the environment variable automatically.
@jonathanpeppers jonathanpeppers added the Area: App+Library Build Issues when building Library projects or Application projects. label Jun 10, 2021
@jonathanpeppers jonathanpeppers added this to the One .NET milestone Jun 10, 2021
@jonathanpeppers jonathanpeppers self-assigned this Jun 10, 2021
jonathanpeppers added a commit to jonathanpeppers/xamarin-android that referenced this issue Jun 16, 2021
@jonathanpeppers
[One .NET] set env var automatically for $(UseInterpreter)
e48a9e4 
Fixes: xamarin#6016
Context: https://github.com/dotnet/maui/blob/main/src/Templates/src/templates/maui-mobile/MauiApp1/Android/AndroidEnvironment.txt

Currently, the the .NET MAUI project template includes a
`@(AndroidEnvironment)` file for "Hot Reload" scenarios. Let's setup
this value by default so it will not be needed.
@jonathanpeppers jonathanpeppers mentioned this issue Jun 16, 2021
Merged
jonathanpeppers added a commit that referenced this issue Jun 18, 2021
@jonathanpeppers
[One .NET] set env var automatically for $(UseInterpreter) (#6027)
ee49249 
Fixes: #6016
Context: https://github.com/dotnet/maui/blob/main/src/Templates/src/templates/maui-mobile/MauiApp1/Android/AndroidEnvironment.txt

Currently, the the .NET MAUI project template includes a
`@(AndroidEnvironment)` file for "Hot Reload" scenarios. Let's setup
this value by default so it will not be needed.
@xamarin xamarin locked as resolved and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonathanpeppers jonathanpeppers

Labels
Area: App+Library Build Issues when building Library projects or Application projects.
Projects
None yet
Milestone
.NET 6
Development

Successfully merging a pull request may close this issue.

[One .NET] set env var automatically for $(UseInterpreter) jonathanpeppers/xamarin-android
1 participant
@jonathanpeppers