Update xUnit packages to the latest versions #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
pushed a commit
that referenced
this pull request
Aug 3, 2018
(From the "cross your fingers and hope this works" department...) Context: https://jenkins.mono-project.com/job/xamarin-android-pr-builder/3574/ A Jenkins build is UNSTABLE when any unit tests fail. In the case of [PR Build #3574][0], there were no reported test failures, so what went wrong? Further investigation showed that an on-device unit test was crashing: /Users/builder/android-toolchain/sdk/platform-tools/adb -s emulator-5570 shell am instrument -w "Xamarin.Android.Bcl_Tests/xamarin.android.bcltests.NUnitInstrumentation" INSTRUMENTATION_RESULT: shortMsg=Process crashed. The unit test was in turn crashing because of an unhandled exception: E/mono ( 4120): Unhandled Exception: (TaskId:115) E/mono ( 4120): System.IO.IOException: Unable to read data from the transport connection: Connection reset by peer. ---> System.Net.Sockets.SocketException: Connection reset by peer (TaskId:115) E/mono ( 4120): at System.Net.Sockets.Socket.Receive (System.Byte[] buffer, System.Int32 offset, System.Int32 size, System.Net.Sockets.SocketFlags socketFlags) [0x00017] in /Users/builder/jenkins/workspace/xamarin-android/xamarin-android/external/mono/mcs/class/referencesource/System/net/System/Net/Sockets/Socket.cs:1773 (TaskId:115) E/mono ( 4120): at System.Net.Sockets.NetworkStream.Read (System.Byte[] buffer, System.Int32 offset, System.Int32 size) [0x0009b] in /Users/builder/jenkins/workspace/xamarin-android/xamarin-android/external/mono/mcs/class/referencesource/System/net/System/Net/Sockets/NetworkStream.cs:513 (TaskId:115) E/mono ( 4120): --- End of inner exception stack trace --- (TaskId:115) E/mono ( 4120): at System.Net.Sockets.NetworkStream.Read (System.Byte[] buffer, System.Int32 offset, System.Int32 size) [0x000c3] in /Users/builder/jenkins/workspace/xamarin-android/xamarin-android/external/mono/mcs/class/referencesource/System/net/System/Net/Sockets/NetworkStream.cs:525 (TaskId:115) ... E/mono ( 4120): at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback () [0x00000] in /Users/builder/jenkins/workspace/xamarin-android/xamarin-android/external/mono/mcs/class/referencesource/mscorlib/system/threading/threadpool.cs:1213 (TaskId:115) ... I/Zygote ( 1145): Process 4120 exited cleanly (255) (TaskId:115) This is not a "normally catchable" exception -- it's happening on the ThreadPool -- so our current hypothesis/prayer is that updating xUnit to a newer version will "magically fix things" by xUnit having code to prevent unhandled exceptions from the ThreadPool. Even if that doesn't work, we should be using a newer xUnit anyway, so no harm in bumping. [0]: https://jenkins.mono-project.com/job/xamarin-android-pr-builder/3574/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the xUnit (upstream) runner. The tests completed properly, hopefully it means it now handles all the unhandled exceptions properly (or we were lucky this time not to hit the network issue which caused the unhandled exception previously).