[Xamarin.Android.Build.Tasks] Rework target order so _ValidateAndroidPackageProperties is called early. #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PackageProperties is called early. Context https://bugzilla.xamarin.com/show_bug.cgi?id=46931 Rather than have a bunch of DependsOn calls to _ValidateAndroidPackageProperties we just need to rework the order so that this target is called early as part of the Build target. Once we do this we can revert the commit 5fc80f27 which broke the build.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context https://bugzilla.xamarin.com/show_bug.cgi?id=46931
Rather than have a bunch of DependsOn calls to _ValidateAndroidPackageProperties we
just need to rework the order so that this target is called early as part of the
Build target.
Once we do this we can revert the commit 5fc80f27 which broke the build.