[Xamarin.Android.Build.Tasks] Fix up lint output resource paths. #3368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I might try to unify the Resource path fix up in to a central location. |
Fixes xamarin#3360 The lint tool is run against our `$(IntermediateOutputPath)` directory, as a result we end up with paths which point to that directory. We should be fixing those paths up to point to the normal `Resources` directory in the project, just like we do with `aapt/aapt2`.
jonathanpeppers
approved these changes
Aug 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3360
The lint tool is run against our
$(IntermediateOutputPath)directory, as a result we end up with paths which point to
that directory.
We should be fixing those paths up to point to the normal
Resourcesdirectory in the project, just like we dowith
aapt/aapt2.