Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Xamarin.Android.Build.Tasks] MSBuild target does not properly build incrementally #3674

Merged
merged 3 commits into from Jan 9, 2020
Merged

[Xamarin.Android.Build.Tasks] MSBuild target does not properly build incrementally #3674

merged 3 commits into from Jan 9, 2020

Conversation

dellis1972
Copy link
Contributor

Fixes #2413

We should calculate the values for _ManagedUpdateAndroidResgenInputs
in a target rather than at evaluation time. This is so
we can pick up the correct _AndroidBuildPropertiesCache.

@dellis1972 dellis1972 force-pushed the Issue2413 branch 3 times, most recently from 10a8d80 to d67ce7d Compare October 2, 2019 14:37
@dellis1972 dellis1972 force-pushed the Issue2413 branch 2 times, most recently from 7f44000 to 4ee91a4 Compare October 10, 2019 08:26
@dellis1972 dellis1972 force-pushed the Issue2413 branch 2 times, most recently from 7ff5a49 to f9892eb Compare October 17, 2019 09:55
@dellis1972 dellis1972 marked this pull request as ready for review November 13, 2019 10:39
@dellis1972 dellis1972 force-pushed the Issue2413 branch 2 times, most recently from 2279613 to 67caac2 Compare December 5, 2019 11:53
@dellis1972
[Xamarin.Android.Build.Tasks] MSBuild target does not properly build …
2ed571a 
…incrementally

Fixes xamarin#2413

We should calculate the values for `_ManagedUpdateAndroidResgenInputs`
in a target rather than at evaluation time. This is so
we can pick up the correct `_AndroidBuildPropertiesCache`.
@dellis1972
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dellis1972
Copy link
Contributor Author

Last Failure was

1) Failed : Xamarin.Android.Build.Tests.PerformanceTest.Build_JLO_Change
Exceeded expected time of 8150ms, actual 8200ms
  at Xamarin.Android.Build.Tests.PerformanceTest.Profile (Xamarin.ProjectTools.ProjectBuilder builder, System.Action`1[T] action, System.String caller) [0x00000] in <9ce1f7fb36544fb4b1f305a1c5a353e0>:0 
  at Xamarin.Android.Build.Tests.PerformanceTest.Build_JLO_Change () [0x00000] in <9ce1f7fb36544fb4b1f305a1c5a353e0>:0

My guess is this is good to go.

jonathanpeppers
jonathanpeppers approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the changes here shouldn't even affect the Build_JLO_Change test. I don't see anything in the binlog from it that seems like a build perf regression 👍

@jonathanpeppers jonathanpeppers merged commit 38a10a1 into xamarin:master Jan 9, 2020
@dellis1972 dellis1972 deleted the Issue2413 branch January 9, 2020 15:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Published: 10.3 (d16-6)
Development

Successfully merging this pull request may close these issues.

[_ManagedUpdateAndroidResgen] MSBuild target does not properly build incrementally
3 participants
@dellis1972 @jonathanpeppers @brendanzagaeski