[Xamarin.Android.Build.Tasks] Hitting "System.IO.IOException: Too many open files" when building a large app with AOT and all supported architectures (#493) #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
force-pushed
the
d15-1bug53122
branch
2 times, most recently
from
6d23711
to
74b14d3
Compare
…y open files" when building a large app with AOT and all supported architectures (xamarin#493) Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=53122 There is a problem with libzip in that is does not have an API for Flushing the current items in memory to disk. This was why ZipArchiveEx was introduced in commit 9166e03. This commit reworks the BuildApk task to make sure of this new functinality and to periodically flush the zip to disk. This will reduce the chances of running out of memory. It also adds a unit test which generates and builds an app which has a large number of refernces and assets. This app also gets AOT'd so it should be pushing the system to the limit. Also added code to make sure the cross tools and llc have execute permissions. Added code to make sure we dispose of each process in the Aapt and Aot tasks. This is to ensure any files or pipes these processed have are removed as soon as possible. Updated the unix-distribution-setup.targets to ensure that the cross-arm tooling and llc have the correct execute permissions on MacOS and Linux.
dellis1972
force-pushed
the
d15-1bug53122
branch
from
74b14d3
to
8eaed8d
Compare
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Nov 19, 2019
Changes: xamarin/java.interop@baf43b0...166a6c9 Fixes: xamarin/java.interop#519 * xamarin/java.interop@166a6c9: [Java.Interop-Tests] Remove Reflection from JavaPrimitiveArrayContract (xamarin#521) * xamarin/java.interop@09083d9: [generator] Support empty package names (xamarin#520) * xamarin/java.interop@af3dc77: [build] Set up YAML Azure pipeline. (xamarin#516) * xamarin/java.interop@8602581: [java-interop] Enabling -fPIC on Linux build - part 2 (xamarin#518) * xamarin/java.interop@ff3081d: [build] Migrate library projects to SDK style + netstandard2.0 (xamarin#507) * xamarin/java.interop@f5d29c3: [generator] Ensure all usage of parameter names are escaped the same (xamarin#506) * xamarin/java.interop@17cdf54: Add vscode files so we can build/debug/test from inside the vscode ide (xamarin#513)
jonpryor
added a commit
that referenced
this pull request
Nov 20, 2019
Changes: xamarin/java.interop@baf43b0...166a6c9 Fixes: xamarin/java.interop#519 * xamarin/java.interop@166a6c9: [Java.Interop-Tests] Remove Reflection from JavaPrimitiveArrayContract (#521) * xamarin/java.interop@09083d9: [generator] Support empty package names (#520) * xamarin/java.interop@af3dc77: [build] Set up YAML Azure pipeline. (#516) * xamarin/java.interop@8602581: [java-interop] Enabling -fPIC on Linux build - part 2 (#518) * xamarin/java.interop@ff3081d: [build] Migrate library projects to SDK style + netstandard2.0 (#507) * xamarin/java.interop@f5d29c3: [generator] Ensure all usage of parameter names are escaped the same (#506) * xamarin/java.interop@17cdf54: Add vscode files so we can build/debug/test from inside the vscode ide (#513)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=53122
There is a problem with libzip in that is does not have an
API for Flushing the current items in memory to disk.
This was why ZipArchiveEx was introduced in commit 9166e03.
This commit reworks the BuildApk task to make sure of this
new functinality and to periodically flush the zip to disk.
This will reduce the chances of running out of memory.
It also adds a unit test which generates and builds an app
which has a large number of refernces and assets. This app
also gets AOT'd so it should be pushing the system to the limit.
Also added code to make sure the cross tools and llc have
execute permissions.
Added code to make sure we dispose of each process in the Aapt and
Aot tasks. This is to ensure any files or pipes these processed have
are removed as soon as possible.
Updated the unix-distribution-setup.targets to ensure that the cross-arm
tooling and llc have the correct execute permissions on MacOS and Linux.