-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[One .NET] AOT support #5539
Merged
Merged
[One .NET] AOT support #5539
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 87 additions & 0 deletions
87
...marin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.Aot.targets
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| <!-- | ||
| *********************************************************************************************** | ||
| Microsoft.Android.Sdk.Aot.targets | ||
|
|
||
| .NET 6 AOT support. You can find "legacy" Xamarin.Android AOT support | ||
| in Xamarin.Android.Legacy.targets. | ||
|
|
||
| For <MonoAOTCompiler/> usage, see: | ||
| * https://github.com/dotnet/runtime/blob/15dec9a2aa5a4236d6ba70de2e9c146867b9d2e0/src/tasks/AotCompilerTask/MonoAOTCompiler.cs | ||
| * https://github.com/dotnet/runtime/blob/15dec9a2aa5a4236d6ba70de2e9c146867b9d2e0/src/mono/netcore/nuget/Microsoft.NET.Runtime.MonoAOTCompiler.Task/README.md | ||
|
|
||
| These targets are running within the _ComputeFilesToPublishForRuntimeIdentifiers target. | ||
| They run in a context of an inner build with a single $(RuntimeIdentifier). | ||
|
|
||
| *********************************************************************************************** | ||
| --> | ||
| <Project> | ||
|
|
||
| <!-- | ||
| NOTE: currently, the only way to allow $(AotAssemblies) in | ||
| .csproj files is to import these in the Android workload | ||
| when $(MonoAOTCompilerTasksAssemblyPath) is blank: | ||
| https://github.com/dotnet/runtime/blob/69711860262e44458bbe276393ea3eb9f7a2192a/src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Manifest/WorkloadManifest.targets.in#L20-L25 | ||
| --> | ||
| <ImportGroup Condition=" '$(MonoAOTCompilerTasksAssemblyPath)' == '' and '$(AotAssemblies)' == 'true' "> | ||
| <Import Project="Sdk.props" Sdk="Microsoft.NET.Runtime.MonoAOTCompiler.Task" /> | ||
| <Import Project="Sdk.props" Sdk="Microsoft.NETCore.App.Runtime.AOT.Cross.android-x86" /> | ||
| <Import Project="Sdk.props" Sdk="Microsoft.NETCore.App.Runtime.AOT.Cross.android-x64" /> | ||
| <Import Project="Sdk.props" Sdk="Microsoft.NETCore.App.Runtime.AOT.Cross.android-arm" /> | ||
| <Import Project="Sdk.props" Sdk="Microsoft.NETCore.App.Runtime.AOT.Cross.android-arm64" /> | ||
| </ImportGroup> | ||
|
|
||
| <UsingTask TaskName="Xamarin.Android.Tasks.GetAotArguments" AssemblyFile="$(_XamarinAndroidBuildTasksAssembly)" /> | ||
|
|
||
| <Target Name="_AndroidAotInputs"> | ||
| <ItemGroup> | ||
| <_AndroidAotInputs Include="@(ResolvedFileToPublish)" Condition=" '%(Extension)' == '.dll' " /> | ||
| </ItemGroup> | ||
| </Target> | ||
|
|
||
| <Target Name="_AndroidAot" | ||
| Condition=" '$(AotAssemblies)' == 'true' and '$(RuntimeIdentifier)' != '' " | ||
| DependsOnTargets="_AndroidAotInputs" | ||
| Inputs="@(_AndroidAotInputs)" | ||
| Outputs="$(_AndroidStampDirectory)_AndroidAot.stamp"> | ||
| <GetAotArguments | ||
| AndroidAotMode="$(AndroidAotMode)" | ||
| AndroidNdkDirectory="$(_AndroidNdkDirectory)" | ||
| AndroidBinUtilsDirectory="$(AndroidBinUtilsDirectory)" | ||
| AndroidApiLevel="$(_AndroidApiLevel)" | ||
| MinimumSupportedApiLevel="$(AndroidMinimumSupportedApiLevel)" | ||
| AndroidSequencePointsMode="$(_SequencePointsMode)" | ||
| AotAdditionalArguments="$(AndroidAotAdditionalArguments)" | ||
| AotOutputDirectory="$(_AndroidAotBinDirectory)" | ||
| RuntimeIdentifier="$(RuntimeIdentifier)" | ||
| EnableLLVM="$(EnableLLVM)" | ||
| Profiles="@(_AotProfiles)"> | ||
| <Output PropertyName="_AotArguments" TaskParameter="Arguments" /> | ||
| <Output PropertyName="_LLVMPath" TaskParameter="LLVMPath" /> | ||
| </GetAotArguments> | ||
| <ItemGroup> | ||
| <_MonoAOTAssemblies Include="@(_AndroidAotInputs->'%(FullPath)')" AotArguments="$(_AotArguments)" /> | ||
| </ItemGroup> | ||
| <MakeDir Directories="$(IntermediateOutputPath)aot\" /> | ||
| <MonoAOTCompiler | ||
| Assemblies="@(_MonoAOTAssemblies)" | ||
| CompilerBinaryPath="@(MonoAotCrossCompiler->WithMetadataValue('RuntimeIdentifier', '$(RuntimeIdentifier)'))" | ||
| DisableParallelAot="$(_DisableParallelAot)" | ||
| LibraryFormat="So" | ||
| Mode="$(AndroidAotMode)" | ||
jonathanpeppers marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| OutputDir="$(IntermediateOutputPath)aot\" | ||
| OutputType="Library" | ||
| UseAotDataFile="false" | ||
| UseLLVM="$(EnableLLVM)" | ||
| LLVMPath="$(_LLVMPath)"> | ||
| <Output TaskParameter="CompiledAssemblies" ItemName="_AotCompiledAssemblies" /> | ||
| <Output TaskParameter="FileWrites" ItemName="FileWrites" /> | ||
| </MonoAOTCompiler> | ||
| <Touch Files="$(_AndroidStampDirectory)_AndroidAot.stamp" AlwaysCreate="true" /> | ||
| <ItemGroup> | ||
| <ResolvedFileToPublish | ||
| Include="@(_AotCompiledAssemblies->'%(LibraryFile)')" | ||
| ArchiveFileName="libaot-$([System.IO.Path]::GetFileNameWithoutExtension('%(_AotCompiledAssemblies.LibraryFile)')).so" | ||
| /> | ||
| </ItemGroup> | ||
| </Target> | ||
| </Project> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC we ship LLVM only mode
/cc @akoeplinger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turning on
$(EnableLLVM)does not appear to work quite yet: dotnet/runtime#56386We could make it the default value when it's working, if it makes sense to do so.