[Xamarin.Android.Build.Tasks] fix ArgumentException in GenerateCompressedAssembliesNativeSourceFiles #6032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssedAssembliesNativeSourceFiles Context: https://dev.azure.com/xamarin/public/_build/results?buildId=41853&view=logs&j=9cf5f8f4-c6e1-5b84-8b95-5f96f5b2da57&t=837f1816-7880-57fc-23bc-a709d74f8097&l=22687 dotnet/maui is hitting a build error, such as: error XAGCANSF7004: System.ArgumentException: An entry with the same key already exists. error XAGCANSF7004: at System.ThrowHelper.ThrowArgumentException(ExceptionResource resource) error XAGCANSF7004: at System.Collections.Generic.TreeSet`1.AddIfNotPresent(T item) error XAGCANSF7004: at System.Collections.Generic.SortedDictionary`2.Add(TKey key, TValue value) error XAGCANSF7004: at Xamarin.Android.Tasks.GenerateCompressedAssembliesNativeSourceFiles.GenerateCompressedAssemblySources() error XAGCANSF7004: at Xamarin.Android.Tasks.GenerateCompressedAssembliesNativeSourceFiles.RunTask() error XAGCANSF7004: at Microsoft.Android.Build.Tasks.AndroidTask.Execute() in /Users/builder/azdo/_work/1/s/xamarin-android/external/xamarin-android-tools/src/Microsoft.Android.Build.BaseTasks/AndroidTask.cs:line 17 We believe there is somehow a duplicate assembly, but hard to tell what is happening exactly from the `.binlog`. Reviewing the `<GenerateCompressedAssembliesNativeSourceFiles/>` MSBuild task, it appears the `ContainsKey()` check is not using the correct key for the dictionary. I fixed this issue and added a `LogDebugMessage()` call, so we can figure out what is happening upstream in dotnet/maui.
grendello
approved these changes
Jun 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://dev.azure.com/xamarin/public/_build/results?buildId=41853&view=logs&j=9cf5f8f4-c6e1-5b84-8b95-5f96f5b2da57&t=837f1816-7880-57fc-23bc-a709d74f8097&l=22687
dotnet/maui is hitting a build error, such as:
We believe there is somehow a duplicate assembly, but hard to tell
what is happening exactly from the
.binlog.Reviewing the
<GenerateCompressedAssembliesNativeSourceFiles/>MSBuild task, it appears the
ContainsKey()check is not using thecorrect key for the dictionary.
I fixed this issue and added a
LogDebugMessage()call, so we canfigure out what is happening upstream in dotnet/maui.