[Xamarin.Android.Build.Tasks] NullReferenceException in Xamarin.Android.Common.targets #6126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id.Common.targets Fixes xamarin#6124 Commit 2a04748 removed the `[Required]` attribute from the `KeyPass` and `StorePass` properties. This was because they were now optional. However `keytool` does REQUIRE these parameters when we use the `-ks` or `KeyStore` argument. If a user does not pass these arguments they get the following error ``` error XAAAS7001: System.NullReferenceException: Object reference not set to an instance of an object. error XAAAS7001: at Xamarin.Android.Tasks.AndroidApkSigner.AddStorePass(CommandLineBuilder cmd, String cmdLineSwitch, String value) error XAAAS7001: at Xamarin.Android.Tasks.AndroidApkSigner.GenerateCommandLineCommands() ``` This is because the `KeyPass` or `StorePass` are `null` and the `AddStorePass` function is not handling that. So what we should do is when the `KeyStore` argument is being used we should error out if `KeyPass` or `StorePass` are empty or `null`.
jonathanpeppers
approved these changes
Jul 27, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6124
Commit 2a04748 removed the
[Required]attribute from theKeyPassand
StorePassproperties. This was because they were now optional.However
keytooldoes REQUIRE these parameters when we use the-ksor
KeyStoreargument.If a user does not pass these arguments they get the following error
This is because the
KeyPassorStorePassarenulland theAddStorePassfunction is not handling that.
So what we should do is when the
KeyStoreargument is being used we shoulderror out if
KeyPassorStorePassare empty ornull.