[One .NET] prefer /manifest/@android:versionCode #6383
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6384
Fixes: dotnet/sdk#21614
In .NET 6, you can't currently put
versionCode
inAndroidManifest.xml
, as it is always overwritten by a default:We should actually check if the value is present in
AndroidManifest.xml
and only set if blank.The other new MSBuild properties don't appear to suffer from this
problem:
$(ApplicationId)
$(ApplicationTitle)
$(ApplicationDisplayVersion)
This is because we don't default these properties to a value when they
are blank.
I added a new test for this scenario.