DesignTime Builds should honour AndroidGenerateResourceDesigner. #6844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
approved these changes
Mar 24, 2022
Fixes: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1440274
In some circumstances, when
[`$(AndroidGenerateResourceDesigner)`][0]=False and a custom
`Resource.Designer.cs` is provided in the project, loading a project
would cause Visual Studio IntelliSense to show an ambiguity with e.g.
`Resource.Layout.activity_main`, as the member exists in *both* the
custom `Resource.Designer.cs` *and* in the design-time-generated
`Resource.Designer.cs`.
This was because the design-time build was not taking
`$(AndroidGenerateResourceDesigner)` into consideration before
generating `Resource.designer.cs`. Consequently, we would *always*
create a `Resource.designer.cs` file into the `designtime` directory.
Fix this by turning off the `designtime` build when
`$(AndroidGenerateResourceDesigner)`=False.
Additionally, update `Xamarin.Android.Legacy.targets` so that
`$(AndroidGenerateResourceDesigner)` is *always* set in Legacy builds,
with a default value of True. This is to get around some issues under
legacy where `$(AndroidGenerateResourceDesigner)` was not defined.
This is because the `designtime` build tasks and targets are shared
between both Classic and .NET 6 build systems.
[0]: https://github.com/xamarin/xamarin-android/blob/4b33a6229c9babde795dea48d20ca86d8f9f9c97/Documentation/guides/building-apps/build-properties.md#androidgenerateresourcedesigner |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1440274
The design time build was not taking into account the
AndroidGenerateResourceDesignerproperty value.As a result we would always get a
Resource.designer.csfile generated in the designtime directory.So lets turn off the designtime build if that property is set.
Also note set a defaut for
AndroidGenerateResourceDesignerin legacy so that it is alwaystrue.This is to get around some issues under legacy where
AndroidGenerateResourceDesignerwas notdefined. This is because the designtime build tasks and targets are shared between both systems.