Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XABT] Port class-parse/generator response file space fix from 67ce902c. #7106

Merged
merged 1 commit into from Jun 17, 2022

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Jun 16, 2022

Fixes: dotnet/maui#8049

There was a bug causing response files to not work when trying to bind Java libraries in a path containing a space, since the CLI argument given to class-parse/generator was not properly quoted.

This has been fixed in PR #5926, however this is a .NET 7 only PR.

Pull the fix out of that PR and port it to the 6.0.4xx branch so it will go into a .NET 6 servicing release.

@jpobst jpobst marked this pull request as ready for review June 16, 2022 21:36
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I backported b21267f to see if some of these NDK test failures are fixed on this release/6.0.4xx branch.

Let me see how the latest run goes, and we might just rebase or /azp run this one again.

@jonpryor
Copy link
Member

@jonathanpeppers , @jpobst: I think we need to cherry-pick 20365df to this release branch in order to fix the Windows bot unit test failures, e.g. BuildApplicationWithMonoEnvironment("Normal") https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6297093&view=ms.vss-test-web.build-test-results-tab&runId=44169750&resultId=100053&paneView=debug

System.ComponentModel.Win32Exception : An error occurred trying to start process 'C:\Android\android-sdk\ndk-bundle\toolchains\llvm\prebuilt\windows-x86_64\bin\readelf' with working directory 'C:\a_work\1\s\bin\TestRelease\net6.0'. The system cannot find the file specified.
   at System.Diagnostics.Process.StartWithCreateProcess(ProcessStartInfo startInfo)
   at Xamarin.Android.Build.Tests.EnvironmentHelper.AssertSharedLibraryHasRequiredSymbols(String dsoPath, String readElfPath) in C:\a\_work\1\s\src\Xamarin.Android.Build.Tasks\Tests\Xamarin.Android.Build.Tests\Utilities\EnvironmentHelper.cs:line 472
   at Xamarin.Android.Build.Tests.EnvironmentHelper.AssertValidEnvironmentSharedLibrary(String outputDirectoryRoot, String sdkDirectory, String ndkDirectory, String supportedAbis) in C:\a\_work\1\s\src\Xamarin.Android.Build.Tasks\Tests\Xamarin.Android.Build.Tests\Utilities\EnvironmentHelper.cs:line 432
   at Xamarin.Android.Build.Tests.EnvironmentContentTests.BuildApplicationWithMonoEnvironment(String sequencePointsMode) in C:\a\_work\1\s\src\Xamarin.Android.Build.Tasks\Tests\Xamarin.Android.Build.Tests\EnvironmentContentTests.cs:line 63

@jonathanpeppers
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jonathanpeppers
Copy link
Member

Ok, the test failures look better this time. They look unrelated.

@jonathanpeppers jonathanpeppers merged commit 64ecc3e into release/6.0.4xx Jun 17, 2022
@jonathanpeppers jonathanpeppers deleted the rsp-fix branch June 17, 2022 18:15
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants