-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Xamarin.Android.Build.Tasks] Add XA1031 error for AndroidHttpClientHandlerType
#7448
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
389ac6e
[Xamarin.Android.Build.Tasks] Add XA1031 error for `AndroidHttpClient…
dellis1972 e4e0481
Back out changes to ProjectBuilder
dellis1972 b8be51b
Run the _CheckAndroidHttpClientHandlerType just after compile
dellis1972 a67c526
Move the _CheckAndroidHttpClientHandlerType
dellis1972 2562dca
Fix unit test under Legacy
dellis1972 121eb1c
Remove System.Net.Http.MonoWebRequestHandler test as it is redundant
dellis1972 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
--- | ||
title: Xamarin.Android error XA1031 | ||
description: XA1031 error code | ||
ms.date: 10/10/2022 | ||
--- | ||
# Xamarin.Android error XA1031 | ||
|
||
## Example messages | ||
|
||
``` | ||
The 'AndroidHttpClientHandlerType' property value 'Foo.Bar.HttpHander, MyApp' must derive from 'System.Net.Http.HttpMessageHandler'. | ||
Please change the value to an assembly-qualifed type name which inherits from '{1}' or remove the property completely. | ||
``` | ||
|
||
## Solution | ||
|
||
Edit your csproj directly and change the 'AndroidHttpClientHandlerType' to | ||
a valid value. | ||
|
||
Valid values can be found at `~/android/deploy-test/building-apps/build-properties.md#AndroidHttpClientHandlerType`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
--- | ||
title: Xamarin.Android error XA1032 | ||
description: XA1032 error code | ||
ms.date: 10/10/2022 | ||
--- | ||
# Xamarin.Android error XA1032 | ||
|
||
## Example messages | ||
|
||
``` | ||
Failed to resolve '{0}' from '{1}'. Please check your `AndroidHttpClientHandlerType` setting. | ||
``` | ||
|
||
## Solution | ||
|
||
Edit your csproj directly and change the 'AndroidHttpClientHandlerType' to | ||
a valid value. | ||
|
||
Valid values can be found at `~/android/deploy-test/building-apps/build-properties.md#AndroidHttpClientHandlerType`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
--- | ||
title: Xamarin.Android error XA1033 | ||
description: XA1033 error code | ||
ms.date: 10/10/2022 | ||
--- | ||
# Xamarin.Android error XA1033 | ||
|
||
## Example messages | ||
|
||
``` | ||
Could not resolve '{0}'. Please check your `AndroidHttpClientHandlerType` setting. | ||
``` | ||
|
||
## Solution | ||
|
||
Edit your csproj directly and change the 'AndroidHttpClientHandlerType' to | ||
a valid value. | ||
|
||
Valid values can be found at `~/android/deploy-test/building-apps/build-properties.md#AndroidHttpClientHandlerType`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dellis1972 : this feels like something that should be called out in the commit message. What's the rationale here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is left over. But we got info from the runtime team that if a user defines
System.Net.Http.SocketsHttpHandler'
as the handler type they MUST use set theUseNativeHttpHandler
msbuild property. Otherwise it doesn't work.This is where the conversaton took place https://discord.com/channels/732297728826277939/732297837953679412/1029777522897993748
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove it ("this is left over") or keep it ("extract rationale from Discord")?