Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused build-tools/timing. #8563

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Remove unused build-tools/timing. #8563

merged 1 commit into from
Dec 6, 2023

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Dec 5, 2023

Context: dotnet/android-tools#220
Context: #8545

We added the ability for consumers of MSBuild NuGet packages to not add the Microsoft.Build package to their project. One project that currently still requires Microsoft.Build is Xamarin.Android.BootstrapTasks.

However the only thing that uses Microsoft.Build is TimingLogger which produced a build performance report for our old Jenkins build system. As we no longer use Jenkins or this code, removing it allows us to remove the Microsoft.Build dependency.

Removes warnings:

C:\a\_work\1\s\build-tools\Xamarin.Android.Tools.BootstrapTasks\Xamarin.Android.Tools.BootstrapTasks.csproj : warning NU1701: Package 'Microsoft.Build 17.8.3' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project. [C:\a\_work\1\s\Xamarin.Android.BootstrapTasks.sln]
C:\a\_work\1\s\build-tools\Xamarin.Android.Tools.BootstrapTasks\Xamarin.Android.Tools.BootstrapTasks.csproj : warning NU1701: Package 'Microsoft.IO.Redist 6.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project. [C:\a\_work\1\s\Xamarin.Android.BootstrapTasks.sln]

This reduces the number of CI reported warnings from 166 to 56.

@jpobst jpobst marked this pull request as ready for review December 6, 2023 17:51
@jpobst jpobst requested a review from grendello December 6, 2023 17:51
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I think this thing was created before .binlog files existed, as a custom MSBuild logger for timings. If we ever needed this information again, we'd probably just use MSBuild.StructuredLogger to open .binlog files instead.

@jpobst jpobst merged commit 37792c4 into main Dec 6, 2023
45 of 47 checks passed
@jpobst jpobst deleted the remove-timing branch December 6, 2023 21:14
grendello added a commit that referenced this pull request Dec 7, 2023
* main:
  [build] Use xamarin owned lz4 and robin-map forks (#8567)
  Remove unused `build-tools/timing`. (#8563)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants