-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] use dotnet/maui/net9.0
branch
#8614
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `MAUI Integration` test lane is currently failing with: Unhandled exception: Microsoft.NET.Sdk.WorkloadManifestReader.WorkloadManifestCompositionException: Could not find workload 'microsoft-net-runtime-android-net8' extended by workload 'android' in manifest 'microsoft.net.sdk.android' [C:\a\_work\1\s\maui\bin\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.android\WorkloadManifest.json] at Microsoft.NET.Sdk.WorkloadManifestReader.WorkloadResolver.<>c__DisplayClass26_0.<<EnumerateWorkloadWithExtends>g__EnumerateWorkloadWithExtendsRec|0>d.MoveNext() at System.Linq.Enumerable.AppendPrependIterator`1.LoadFromEnumerator() at System.Linq.Enumerable.AppendPrepend1Iterator`1.MoveNext() at System.Linq.Enumerable.All[TSource](IEnumerable`1 source, Func`2 predicate) at Microsoft.NET.Sdk.WorkloadManifestReader.WorkloadResolver.GetAvailableWorkloadDefinitions()+MoveNext() at System.Linq.Enumerable.SelectEnumerableIterator`2.MoveNext() at System.Linq.Enumerable.Contains[TSource](IEnumerable`1 source, TSource value, IEqualityComparer`1 comparer) at Microsoft.DotNet.Workloads.Workload.Install.WorkloadInstallCommand.ValidateWorkloadIdsInput() at Microsoft.DotNet.Workloads.Workload.Install.WorkloadInstallCommand..ctor(ParseResult parseResult, IReporter reporter, IWorkloadResolverFactory workloadResolverFactory, IInstaller workloadInstaller, INuGetPackageDownloader nugetPackageDownloader, IWorkloadManifestUpdater workloadManifestUpdater, String tempDirPath, IReadOnlyCollection`1 workloadIds) at Microsoft.DotNet.Cli.WorkloadInstallCommandParser.<>c.<ConstructCommand>b__6_0(ParseResult parseResult) at System.CommandLine.Invocation.InvocationPipeline.Invoke(ParseResult parseResult) at Microsoft.DotNet.Cli.Program.ProcessArgs(String[] args, TimeSpan startupTime, ITelemetry telemetryClient) C:\a\_work\1\s\maui\src\DotNet\DotNet.csproj(198,5): error MSB3073: The command ""C:\a\_work\1\s\maui\bin/dotnet/dotnet" workload install android --skip-sign-check --skip-manifest-update --verbosity diag --temp-dir "C:\a\_work\1\s\maui\bin/temp/" --configfile "C:\a\_work\1\s\maui\NuGet.config"" exited with code 1. This is likely just due to the fact that it's using the `dotnet/maui/net8.0` branch. Hopefully, switching to the proper branch fixes things.
Ok this makes it much further, but we get:
Is there something that is supposed to skip the iOS build? Maybe it's not working. |
To avoid failure during `restore`: error NETSDK1139: The target platform identifier ios was not recognized.
pjcollins
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're green!
grendello
added a commit
that referenced
this pull request
Jan 8, 2024
* main: [tests] fix `MAUI Integration` lane (#8614) [xaprepare] use `$(XAPackagesDir)` for NuGet folder (#8613) Add ApiScan to nightly build (#8605) Bump to dotnet/installer@29db8a1157 9.0.100-alpha.1.23628.5 (#8611) [Mono.Android] Fix ServerCertificateCustomValidator (#8594) Bump to dotnet/installer@e08874da58 9.0.100-alpha.1.23625.1 Bump to dotnet/installer@fae23c6571 9.0.100-alpha.1.23618.2 Localized file check-in by OneLocBuild Task (#8589) [tests] enable Xamarin.Android.LibraryProjectZip-LibBinding test (#8588)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MAUI Integration
test lane is currently failing with:This is likely just due to the fact that it's using the
dotnet/maui/net8.0
branch. Hopefully, switching to the proper branch fixes things.