[Xamarin.Android.Build.Tasks] Null Reference Exceoption when getting android.jar #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
reviewed
Oct 25, 2017
| @@ -69,7 +69,8 @@ public override bool Execute () | |||
| } | |||
|
|
|||
| platform = GetTargetSdkVersion (platform, target_sdk); | |||
| JavaPlatformJarPath = Path.Combine (MonoAndroidHelper.AndroidSdk.TryGetPlatformDirectoryFromApiLevel (platform, MonoAndroidHelper.SupportedVersions), "android.jar"); | |||
| var platformPath = MonoAndroidHelper.AndroidSdk.TryGetPlatformDirectoryFromApiLevel (platform, MonoAndroidHelper.SupportedVersions); | |||
| JavaPlatformJarPath = Path.Combine (platformPath ?? MonoAndroidHelper.AndroidSdk.GetPlatformDirectoryFromId (platform), "android.jar"); | |||
There was a problem hiding this comment.
I think it would make more sense to instead emit an error if TryGetPlatformDirectoryFromApiLevel() fails, especially considering that TryGetPlatformDirectoryFromApiLevel() calls GetPlatformDirectoryFromId().
If null is returned, it's because the directory doesn't exist.
Thus, I think we should instead have:
static string TryGetAndroidJarPath (TaskLoggingHelper log, string platform)
{
var platformPath = MonoAndroidHelper.AndroidSdk.TryGetPlatformDirectoryFromApiLevel (platform, MonoAndroidHelper.SupportedVersions);
if (platformPath == null) {
log.LogError ("XA1234", $"Could not determine Android SDK directory for {platform}.");
return null;
}
return Path.Combine (platformPath, "android.jar");
}The one downside here is that we don't see the directories that we're trying. I'm not sure that's a problem.
…android.jar Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=60324 If a android.jar file does NOT exist for a target platform we should raise a normal error. But we currently throw a null reference exception. `TryGetPlatformDirectoryFromApiLevel` can return null, this is by design. So we need to handle that in the places where its used. And return a reasonable error message if we do get a null back.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=60324
If a android.jar file does NOT exist for a target platform we should
raise a normal error. But we currently throw a null reference
exception.
TryGetPlatformDirectoryFromApiLevelcan return null, this is bydesign. So we need to handle that in the places where its used.
And return a reasonable error message if we do get a null back.