Skip to content

Commit

Permalink
[BGTasks] Do not make BGTask abstract. (#8676)
Browse files Browse the repository at this point in the history 
The class in the API is abstract, the problem is that when the
application goes to the background, when it gets back we try to
instantiate an abstract class probably because Apple returns a internal
type that we do not know about.

fixes: #7456

Co-authored-by: Manuel de la Pena <mandel@microsoft.com>
  • Loading branch information
@monojenkins @mandel-macaque
monojenkins and mandel-macaque committed May 26, 2020
1 parent 7af99d6 commit 29c4ea7
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/backgroundtasks.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ interface BGTaskRequest : NSCopying {
NSDate EarliestBeginDate { get; set; }
}

[Abstract]
[TV (13,0), NoWatch, NoMac, iOS (13,0)]
[BaseType (typeof (NSObject))]
[DisableDefaultCtor]
Expand Down

7 comments on commit 29c4ea7

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Jenkins job (on internal Jenkins) succeeded

✅ Build succeeded
✅ Packages:

✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)
✅ Test run succeeded

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Device tests passed on iOS on Azure DevOps(iOS): Html Report ✅

🎉 All 150 tests passed 🎉

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Status for 'xamarin-macios - sample testing (build)': failure.

  • ✅ Debug_iPhone_AF: Succeeded
  • ✅ Debug_iPhone_GR: Succeeded
  • ✅ Debug_iPhone_SZ: Succeeded
  • ✅ Debug_iPhoneSimulator: Succeeded
  • ✅ Release_iPhone_AF: Succeeded
  • ✅ Release_iPhone_GR: Succeeded
  • ❌ Release_iPhone_SZ:
  • ✅ Release_iPhoneSimulator: Succeeded
  • ✅ Debug_Mac: Succeeded
  • ✅ Release_Mac: Succeeded
  • ✅ PublishPerformanceData: Succeeded

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Status for 'xamarin-macios - sample testing (build)': success.

  • ✅ Debug_iPhone_AF: Succeeded
  • ✅ Debug_iPhone_GR: Succeeded
  • ✅ Debug_iPhone_SZ: Succeeded
  • ✅ Debug_iPhoneSimulator: Succeeded
  • ✅ Release_iPhone_AF: Succeeded
  • ✅ Release_iPhone_GR: Succeeded
  • ✅ Release_iPhone_SZ: Succeeded
  • ✅ Release_iPhoneSimulator: Succeeded
  • ✅ Debug_Mac: Succeeded
  • ✅ Release_Mac: Succeeded
  • ✅ PublishPerformanceData: Succeeded

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Running XM tests on '10.10', Running XM tests on '10.12', Running XM tests on '10.9', Running XM tests on '10.9'' 🔥

✅ Build succeeded
✅ Packages:

✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)
🔥 Xamarin.Mac tests on 10.10 failed: Xamarin.Mac tests on macOS 10.10 failed (apitest) 🔥
🔥 Xamarin.Mac tests on 10.12 failed: Xamarin.Mac tests on macOS 10.12 failed (apitest) 🔥
🔥 Xamarin.Mac tests on 10.9 failed: script returned exit code 143 🔥
🔥 Test run failed 🔥

Test results

1 tests failed, 182 tests passed.

Failed tests

  • Xtro/Mac: BuildFailure

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Device tests completed (Failed) on iOS on Azure DevOps(iOS): Html Report 🔥

Test results

1 tests failed, 149 tests passed.

Failed tests

  • [xUnit] Mono SystemCoreXunit Part 2/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): TimedOut

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Status for 'xamarin-macios - sample testing (build)': failure.

  • ❌ Debug_iPhone_AF: Failed
  • ❌ Debug_iPhone_GR: Failed
  • ❌ Debug_iPhone_SZ: Failed
  • ❌ Debug_iPhoneSimulator: Failed
  • ❌ Release_iPhone_AF: Failed
  • ❌ Release_iPhone_GR: Failed
  • ❌ Release_iPhone_SZ: Failed
  • ❌ Release_iPhoneSimulator: Failed
  • ❌ Debug_Mac: Failed
  • ❌ Release_Mac: Failed
  • ✅ PublishPerformanceData: Succeeded

Please sign in to comment.