Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[dotnet] Fix dependencies for Microsoft.<platform>.Sdk.DefaultItems.p…
…rops. (#20478) Make sure Microsoft.\<platform\>.Sdk.DefaultItems.props is rebuilt if the current hash changes. This fixes a local rebuild issue, where we'd rebuild Microsoft.\<platform\>.Sdk.Versions.props, but not Microsoft.\<platform\>.Sdk.DefaultItems.props. A build failure like this would thus result: tools/msbuild/iOS/Xamarin.Shared.targets(606,3): error : A bundle identifier is required. Either add an 'ApplicationId' property in the project file, or add a 'CFBundleIdentifier' entry in the project's Info.plist file. because: * We store the current git hash in both of the files mentioned above. * We only include default items in a build if the git hashes match. * Since the files weren't both rebuilt, they'd contain different hashes, and thus we wouldn't include Info.plist in the build, leading to the build error.
- Loading branch information
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
Sorry, something went wrong.
45ac791
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 [CI Build] Test results 🔥
Test results
❌ Tests failed on VSTS: test results
14 tests crashed, 1 tests failed, 35 tests passed.
Failures
❌ cecil tests
Html Report (VSDrops) Download
❌ dotnettests tests (MacCatalyst)
🔥 Failed catastrophically on VSTS: test results - dotnettests_maccatalyst (no summary found).
Html Report (VSDrops) Download
❌ generator tests
🔥 Failed catastrophically on VSTS: test results - generator (no summary found).
Html Report (VSDrops) Download
❌ install-source tests
🔥 Failed catastrophically on VSTS: test results - install-source (no summary found).
Html Report (VSDrops) Download
❌ interdependent-binding-projects tests
🔥 Failed catastrophically on VSTS: test results - interdependent-binding-projects (no summary found).
Html Report (VSDrops) Download
❌ introspection tests
🔥 Failed catastrophically on VSTS: test results - introspection (no summary found).
Html Report (VSDrops) Download
❌ linker tests
🔥 Failed catastrophically on VSTS: test results - linker (no summary found).
Html Report (VSDrops) Download
❌ mac-binding-project tests
🔥 Failed catastrophically on VSTS: test results - mac-binding-project (no summary found).
Html Report (VSDrops) Download
❌ mmp tests
🔥 Failed catastrophically on VSTS: test results - mmp (no summary found).
Html Report (VSDrops) Download
❌ mononative tests
🔥 Failed catastrophically on VSTS: test results - mononative (no summary found).
Html Report (VSDrops) Download
❌ monotouch tests (iOS)
🔥 Failed catastrophically on VSTS: test results - monotouch_ios (no summary found).
Html Report (VSDrops) Download
❌ monotouch tests (MacCatalyst)
🔥 Failed catastrophically on VSTS: test results - monotouch_maccatalyst (no summary found).
Html Report (VSDrops) Download
❌ monotouch tests (macOS)
🔥 Failed catastrophically on VSTS: test results - monotouch_macos (no summary found).
Html Report (VSDrops) Download
❌ monotouch tests (tvOS)
🔥 Failed catastrophically on VSTS: test results - monotouch_tvos (no summary found).
Html Report (VSDrops) Download
❌ monotouch tests (watchOS)
🔥 Failed catastrophically on VSTS: test results - monotouch_watchos (no summary found).
Html Report (VSDrops) Download
Successes
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download
Pipeline on Agent
Hash: 45ac791f35f14ecfb45092c099708812ae9db552 [CI build]