Skip to content

Commit

Permalink
Fix intro test failures for CIRawFilter
Browse files Browse the repository at this point in the history
from Sebastien: "most filters are key-based natively (not-NSObject subclasses)) and we expose them as C# _user-type_ CIFilter-subclasses in recent years _most_ filters have also been exposed natively as protocols (not classes), we expose them as `*Protocol` interface types `CIRAWFilter` is a special case, it's a native `CIFilter` subclass so we're not using [CoreImageFilter] and [CoreImageFilterProperty] attributes to define it which also means we cannot use the "extra" tests to validate the filter properties. So we skip it here. Do not fear it's still tested, like any _normal_, NSObject subclass we have bound :-)"
  • Loading branch information
rachelkang committed Sep 1, 2021
1 parent 4dd7a01 commit b3869af
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/coreimage.cs
Expand Up @@ -729,7 +729,7 @@ public enum CIRawDecoderVersion : long {

[iOS (15,0), Mac (12,0), MacCatalyst (15,0), TV (15,0)]
[BaseType (typeof(CIFilter), Name="CIRAWFilter")]
interface CIRawFilter
interface CIRawFilter : CIFilterProtocol
{
[Static]
[Export ("supportedCameraModels")]
Expand Down
2 changes: 2 additions & 0 deletions tests/introspection/ApiCoreImageFiltersTest.cs
Expand Up @@ -59,6 +59,8 @@ protected virtual bool Skip (Type type)
protected virtual bool Skip (string nativeName)
{
switch (nativeName) {
case "CIRawFilter":
return true;
// Both reported in radar #21548819
// NSUnknownKeyException [<CIDepthOfField 0x158586970> valueForUndefinedKey:]: this class is not key value coding-compliant for the key inputPoint2.
case "CIDepthOfField":
Expand Down

0 comments on commit b3869af

Please sign in to comment.