Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[introspection] Use <= when comparing minimum OS versions #11029

Closed
spouliot opened this issue Mar 30, 2021 · 0 comments · Fixed by #17090
Closed

[introspection] Use <= when comparing minimum OS versions #11029

spouliot opened this issue Mar 30, 2021 · 0 comments · Fixed by #17090
Assignees
@rolfbjarne
Labels
iOS Issues affecting Xamarin.iOS macOS Issues affecting Xamarin.Mac test-only-issue The issue only affects tests
Projects
.NET 8 - Themes
Milestone
.NET 8

Comments

@spouliot
Copy link
Contributor

spouliot commented Mar 30, 2021 •
edited

There's no value in having a minimum of macOS 10.9 and decorating some (not all) API with the same version.

However this requires a bunch of, non urgent, updates:

  • iOS 64 bits: Introduced: 149 API with unneeded or incorrect version information
  • Mac Modern: Introduced: 347 API with unneeded or incorrect version information

tvOS and watchOS are all done (very few)

Need to be done after PR #10580 is merged.
@spouliot spouliot added macOS Issues affecting Xamarin.Mac iOS Issues affecting Xamarin.iOS test-only-issue The issue only affects tests labels Mar 30, 2021
@spouliot spouliot added this to the Future milestone Mar 30, 2021
spouliot pushed a commit to spouliot/xamarin-macios that referenced this issue Mar 30, 2021
Reduce required churn, at least temporarily
286014b 
Tracking with xamarin#11029
@rolfbjarne rolfbjarne modified the milestones: Future, .NET 8 Oct 7, 2022
@rolfbjarne rolfbjarne added this to Testing in .NET 8 - Themes Oct 7, 2022
@rolfbjarne rolfbjarne self-assigned this Dec 19, 2022
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Dec 20, 2022
@rolfbjarne
[src/generator/tests] Verify that availability attributes don't inclu…
f7ae574 
…de useless version information. Fixes xamarin#11029.

* Change the generator to not write the version in SupportedOSPlatform
  attributes unless it's greater than min OS version.
* Fix a few redundant Mac Catalyst availability versions.
* Uncomment the test to verify that availability attributes don't include
  useless version information.

Fixes xamarin#11029.
@rolfbjarne rolfbjarne mentioned this issue Dec 20, 2022
Merged
.NET 8 - Themes automation moved this from Testing to Done Dec 21, 2022
rolfbjarne added a commit that referenced this issue Dec 21, 2022
@rolfbjarne
[src/generator/tests] Verify that availability attributes don't inclu…
d9bae59 
…de useless version information. Fixes #11029. (#17090)

* Change the generator to not write the version in SupportedOSPlatform
  attributes unless it's greater than min OS version.
* Fix a few redundant Mac Catalyst availability versions.
* Uncomment the test to verify that availability attributes don't include
  useless version information.

Fixes #11029.
@ghost ghost locked as resolved and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rolfbjarne rolfbjarne

Labels
iOS Issues affecting Xamarin.iOS macOS Issues affecting Xamarin.Mac test-only-issue The issue only affects tests
Projects
No open projects
.NET 8 - Themes
Done
Milestone
.NET 8
2 participants
@rolfbjarne @spouliot