Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSKey enum is missing F17 #17085

Closed
emberTrev opened this issue Dec 20, 2022 · 0 comments · Fixed by #17086
Closed

NSKey enum is missing F17 #17085

emberTrev opened this issue Dec 20, 2022 · 0 comments · Fixed by #17086
Labels
enhancement The issue or pull request is an enhancement missing-api-bindings

Comments

@emberTrev
Copy link

Sorry for not using the template. It seems like overkill for this simple fix.

In src/AppKit/Enums.cs in the enum NSKey, there are values for F1, ..., F20. However F17 has been skipped by accident. Please add it.

F18 = 0x4F,
F19 = 0x50,
F20 = 0x5A,
F5 = 0x60,
F6 = 0x61,
F7 = 0x62,
F3 = 0x63,
F8 = 0x64,
F9 = 0x65,
F11 = 0x67,
F13 = 0x69,
F16 = 0x6A,
F14 = 0x6B,
F10 = 0x6D,
F12 = 0x6F,
F15 = 0x71,
Help = 0x72,
Home = 0x73,
PageUp = 0x74,
F4 = 0x76,
End = 0x77,
F2 = 0x78,
PageDown = 0x79,
F1 = 0x7A,
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Dec 20, 2022
@rolfbjarne
[AppKit] Add missing fields to the NSKey enum. Fixes xamarin#17085.
61ffe65 
Fixes xamarin#17085.
@rolfbjarne rolfbjarne mentioned this issue Dec 20, 2022
Merged
@rolfbjarne rolfbjarne added missing-api-bindings enhancement The issue or pull request is an enhancement labels Dec 20, 2022
rolfbjarne added a commit that referenced this issue Dec 21, 2022
@rolfbjarne
[AppKit] Add missing fields to the NSKey enum. Fixes #17085. (#17086)
fe5abf4 
Fixes #17085.
@ghost ghost locked as resolved and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement The issue or pull request is an enhancement missing-api-bindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AppKit] Add missing fields to the NSKey enum. Fixes #17085. rolfbjarne/xamarin-macios
2 participants
@rolfbjarne @emberTrev