Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put user frameworks in the container app bundle for app extensions #17876

Closed
rolfbjarne opened this issue Mar 22, 2023 · 0 comments · Fixed by #18913
Closed

Put user frameworks in the container app bundle for app extensions #17876

rolfbjarne opened this issue Mar 22, 2023 · 0 comments · Fixed by #18913
Labels
app-size enhancement The issue or pull request is an enhancement
Projects
.NET 8 - Themes
Milestone
.NET 8

Comments

@rolfbjarne
Copy link
Member

Currently app extensions are treated as completely separate apps, and we may end up duplicating user frameworks (the Frameworks/* directory) between the app and any app extensions.

We should figure out a way to improve this.

Two potential ideas come up:

  • A post-build msbuild target that looks for user frameworks in app extensions that also exist in the app container, and deletes them from the app extension if they're identical.
  • Don't copy frameworks to the app for app extensions, but copy frameworks for all contained app extensions when copying frameworks for the container app.
@rolfbjarne rolfbjarne added enhancement The issue or pull request is an enhancement app-size labels Mar 22, 2023
@rolfbjarne rolfbjarne added this to the .NET 8 milestone Mar 22, 2023
@rolfbjarne rolfbjarne mentioned this issue Mar 22, 2023
Open
5 tasks
@rolfbjarne rolfbjarne added this to Optimizations in .NET 8 - Themes Mar 22, 2023
@rolfbjarne rolfbjarne mentioned this issue Aug 17, 2023
Closed
@rolfbjarne rolfbjarne mentioned this issue Sep 1, 2023
Merged
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Sep 1, 2023
@rolfbjarne
[dotnet] Point app extensions to any frameworks in the root app bundle.
ab6e20a 
Fixes xamarin#17876.

Put any frameworks in app extensions in the Frameworks directory in the
containing app bundle. This saves a lot of space if the same framework is used
in both an app extension and the containing project (or multiple app
extensions).

Fixes xamarin#17876.
Fixes xamarin#17679.
.NET 8 - Themes automation moved this from Optimizations to Done Sep 11, 2023
rolfbjarne added a commit that referenced this issue Sep 11, 2023
@rolfbjarne
[dotnet] Point app extensions to any frameworks in the root app bundle.
de762d6 
Fixes #17876. (#18913)

Put any frameworks in app extensions in the Frameworks directory in the
containing app bundle. This saves a lot of space if the same framework is used
in both an app extension and the containing project (or multiple app
extensions).

Fixes #17876.
Fixes #17679.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app-size enhancement The issue or pull request is an enhancement
Projects
No open projects
.NET 8 - Themes
Done
Milestone
.NET 8
1 participant
@rolfbjarne